Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HDG sentence incorrectly parsed #235

Closed
tvr256 opened this issue Dec 11, 2022 · 1 comment · Fixed by #237
Closed

HDG sentence incorrectly parsed #235

tvr256 opened this issue Dec 11, 2022 · 1 comment · Fixed by #237

Comments

@tvr256
Copy link

tvr256 commented Dec 11, 2022

As mentioned in SignalK/specification#242 (comment) , the HDG sentence is incorrectly parsed:

If I send the following sentence $INHDG,180,5,W,10,W*6D

navigation.magneticDeviation is not set (should be -5)
navigation.magneticVariation is set to -10 (correct)
navigation.headingCompass is not set (should be 180)
navigation.headingMagnetic is set to 180 (should be 175)
navigation.headingTrue is not set (should be 165)

Incidentally, the NMEA spec clearly states that the first value in the HDG sentence is the magnetic sensor reading before any deviation correction is applied, and not the magnetic heading.

@tkurki
Copy link
Member

tkurki commented Dec 17, 2022

Thanks for the heads up. Please check out the linked PR for the fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants