Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GGA incorrect delta output #91

Open
tkurki opened this issue Sep 10, 2017 · 1 comment
Open

GGA incorrect delta output #91

tkurki opened this issue Sep 10, 2017 · 1 comment

Comments

@tkurki
Copy link
Member

tkurki commented Sep 10, 2017

$GPGGA,200255.00,5310.81257,N,00525.70577,E,2,09,1.12,3.5,M,45.7,M,,0000*5A
generates

{
  "context": "vessels.4F443093",
  "updates": [
    {
      "source": {},
      "timestamp": "2017-09-10T18:41:29.063Z",
      "values": [
        {
          "path": "navigation.gnss",
          "value": {
            "source": {
              "type": "NMEA0183",
              "sentence": "GGA",
              "label": "signalk-parser-nmea0183",
              "talker": "GP"
            },
            "timestamp": "2017-09-10T20:02:00.000Z",
            "quality": 2,
            "satellites": 9,
            "antennaAltitude": 3,
            "horizontalDilution": 1,
            "geoidalSeparation": 45,
            "differentialAge": 0,
            "differentialReference": 0
          }
        }
      ]
    }
  ]
}

where real source is empty and the source data is under value.

@tkurki
Copy link
Member Author

tkurki commented Sep 10, 2017

Furthermore there is no test for GGA that would check delta/full validity, which would have caught this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant