feature: show the status of providers and plugins on the dashboard #591
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
sbender9
commented
Aug 13, 2018
•
sbender9
commented
…th a 'Started' message
tkurki
reviewed
Aug 14, 2018
lib/interfaces/plugins.js
Outdated
| @@ -221,9 +235,22 @@ module.exports = function (app) { | |||
| debug: require('debug')(pluginName), | |||
| registerDeltaInputHandler: handler => { | |||
| onStopHandlers[plugin.id].push(app.registerDeltaInputHandler(handler)) | |||
| }, | |||
| setProviderStatus: (msg, type) => { | |||
| app.setProviderStatus(plugin.id, msg, type) | |||
There was a problem hiding this comment.
Use pluginName here for consistency? As used below.
tkurki
reviewed
Aug 14, 2018
lib/interfaces/plugins.js
Outdated
| plugin.start(getPluginOptions(plugin.id).configuration, restart) | ||
| debug('Started plugin ' + pluginName) | ||
| try { | ||
| plugin.start(getPluginOptions(plugin.id).configuration, restart) |
There was a problem hiding this comment.
We are calling plugin.start, debug and setPluginStartedMessage in several places. Sounds like we need doStartPlugin(...) that does these consistently.
sbender9
changed the title
… 'Startup' status
sbender9
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.