Prefix signals to avoid collisions and security issues. #1322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| { | ||
| internal class ListHelper<T> | ||
| { | ||
| public static readonly IList<T> Empty = new List<T>(); |
There was a problem hiding this comment.
This should be a read only IList i think, to prevent it from being manipulated by reference accidently.
- Prefix all signals with a unique prefix. - Changed various apis to IE<T> to IList<T> - Updated tests. #1320
|
|
||
|
|
||
| internal static string GetConnectionId(string connectionId) | ||
| { |
There was a problem hiding this comment.
Don't we usually make method on internal classes public?
There was a problem hiding this comment.
It's really inconsistent but I'll make them public just since I think that's what the rest are.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevent connections from subscribing to a group that's actually a valid connection ID or Hub name #1320