Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(browse): exponential backoff when OpenAI throttles API calls #214

Closed
wants to merge 15 commits into from
Closed

fix(browse): exponential backoff when OpenAI throttles API calls #214

wants to merge 15 commits into from

Conversation

dbillor
Copy link

@dbillor dbillor commented Apr 5, 2023

adding retry/backoff ability by pulling function out

@dbillor dbillor mentioned this pull request Apr 5, 2023
Closed
brotherko
brotherko reviewed Apr 6, 2023
View reviewed changes
scripts/browse.py Outdated Show resolved Hide resolved
sberney
sberney suggested changes Apr 6, 2023
View reviewed changes
scripts/browse.py Outdated Show resolved Hide resolved
scripts/browse.py Outdated Show resolved Hide resolved
scripts/browse.py Outdated Show resolved Hide resolved
scripts/browse.py Outdated Show resolved Hide resolved
sberney
sberney reviewed Apr 8, 2023
View reviewed changes
Copy link

@sberney sberney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. Can we have a CLI flag to turn this on and off?

scripts/browse.py Outdated Show resolved Hide resolved
nponeccop
nponeccop suggested changes Apr 10, 2023
View reviewed changes
Copy link
Contributor

@nponeccop nponeccop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but needs some whitespace changes

scripts/browse.py Outdated Show resolved Hide resolved
scripts/browse.py Outdated Show resolved Hide resolved
nponeccop
nponeccop suggested changes Apr 10, 2023
View reviewed changes
Copy link
Contributor

@nponeccop nponeccop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove the extra whitespace

nponeccop
nponeccop suggested changes Apr 10, 2023
View reviewed changes
Copy link
Contributor

@nponeccop nponeccop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just 1 place now

scripts/browse.py Outdated Show resolved Hide resolved
nponeccop
nponeccop previously approved these changes Apr 10, 2023
View reviewed changes
@nponeccop nponeccop mentioned this pull request Apr 10, 2023
Closed
1 task
@nponeccop
Copy link
Contributor

@dbillor There are conflicts now

This was referenced Apr 13, 2023
Closed
Closed
Closed
@github-actions github-actions bot added conflicts Automatically applied to PRs with merge conflicts labels Apr 17, 2023
@github-actions
Copy link
Contributor

This pull request has conflicts with the base branch, please resolve those so we can evaluate the pull request.

@nponeccop nponeccop mentioned this pull request Apr 17, 2023
Closed
1 task
@Pwuts Pwuts requested review from BillSchumacher and removed request for sberney and brotherko April 18, 2023 01:17
@github-actions github-actions bot removed the conflicts Automatically applied to PRs with merge conflicts label Apr 18, 2023
@github-actions
Copy link
Contributor

Conflicts have been resolved! 🎉 A maintainer will review the pull request shortly.

@dbillor dbillor requested a review from nponeccop April 18, 2023 16:53
@sadmuphin
Copy link
Contributor

😨

@Pwuts Pwuts mentioned this pull request Apr 18, 2023
Closed
2 tasks
@Pwuts
Copy link
Member

Pwuts commented Apr 18, 2023 •
edited
Loading

Not sure what nuke exploded here, but I think the commit history is broken...

image

nponeccop
nponeccop suggested changes Apr 19, 2023
View reviewed changes
Copy link
Contributor

@nponeccop nponeccop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The merge went wrong

@Pwuts
Copy link
Member

Pwuts commented Apr 19, 2023

@dbillor please fix the commit history so we can merge

tgonzales pushed a commit to tgonzales/Auto-GPT that referenced this pull request Apr 19, 2023
@dependabot
build(deps-dev): bump typescript from 4.9.5 to 5.0.4 (Significant-Gra…
6741975 
…vitas#214)

Bumps [typescript](https://github.com/Microsoft/TypeScript) from 4.9.5 to 5.0.4.
- [Release notes](https://github.com/Microsoft/TypeScript/releases)
- [Commits](microsoft/TypeScript@v4.9.5...v5.0.4)

---
updated-dependencies:
- dependency-name: typescript
  dependency-type: direct:development
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dbillor dbillor requested a review from nponeccop April 19, 2023 20:32
@dbillor
Copy link
Author

dbillor commented Apr 19, 2023

@dbillor please fix the commit history so we can merge

done

This was referenced Apr 20, 2023
Closed
Closed
@AndresCdo
Copy link
Contributor

@dbillor fix formatting using isort.

@dbillor
Copy link
Author

dbillor commented Apr 20, 2023

@dbillor fix formatting using isort.

updated

@Pwuts
Copy link
Member

Pwuts commented Apr 20, 2023

Sorry to disappoint now, but it seems this was already fixed in #1537:
https://github.com/Significant-Gravitas/Auto-GPT/blob/14d3ecaae75a80f03cd118b5767e1c6affb4e3cc/autogpt/llm_utils.py#L96

Also, this PR is currently broken as it applies the edit to scripts/browse.py which doesn't exist anymore.. That decorator is nice though. :)

Closing as duplicate.

@Pwuts Pwuts closed this Apr 20, 2023
@ntindle ntindle mentioned this pull request Apr 25, 2023
Closed
1 task
@anonhostpi anonhostpi mentioned this pull request May 10, 2023
Closed
1 task
waynehamadi added a commit that referenced this pull request Sep 5, 2023
@waynehamadi
Fix export to gdrive (#214)
68ff87d 
Signed-off-by: Merwane Hamadi <merwanehamadi@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BillSchumacher BillSchumacher Awaiting requested review from BillSchumacher

@nponeccop nponeccop Awaiting requested review from nponeccop

@brotherko brotherko Awaiting requested review from brotherko

@sberney sberney Awaiting requested review from sberney

Assignees

@BillSchumacher BillSchumacher

Labels
enhancement New feature or request Obsolete? size/l
Projects
AutoGPT development kanban
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

OpenAI throttling breaks summarization of large files
8 participants
@dbillor @nponeccop @Pwuts @sadmuphin @AndresCdo @sberney @brotherko @BillSchumacher