Don't incapacitate yourself! #1240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lfricken
commented
Apr 15, 2023
|
@lfricken There are conflicts now |
lfricken
force-pushed
the
child-processes
branch
from
10e9a22
to
1073954
Compare
@nponeccop fixed |
nponeccop
previously approved these changes
Apr 15, 2023
|
@lfricken CI fails |
@nponeccop Fixed linting issues and checked tests |
nponeccop
approved these changes
Apr 16, 2023
nponeccop
added
potential plugin
lfricken
commented
Apr 17, 2023
| @@ -38,6 +38,9 @@ def get_prompt() -> str: | |||
| prompt_generator.add_constraint( | |||
| 'Exclusively use the commands listed in double quotes e.g. "command name"' | |||
| ) | |||
| prompt_generator.add_constraint( | |||
| "Use subprocesses for commands that will not terminate within a few minutes" | |||
There was a problem hiding this comment.
It's correct. If the command would terminate within a few minutes (aka quickly) you can use the normal execute command. If it would take more than a few minutes, use subprocess.
p-i-
approved these changes
Apr 17, 2023
laixiao
pushed a commit
to laixiao/Auto-GPT-code
that referenced
this pull request
Apr 18, 2023
* subprocesses * fix lint * fix more lint * fix merge * fix merge again
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
If Auto-GPT4 tries to host a server or do another task that can block the current process, it may get stuck if the command never terminates (somewhat common).
Changes
Adds the
Execute Shell Command Subprocesscommand which uses Popen. Auto-GPT now knows to use this if the command will take too long. When I ask it to host a web server or do other tasks that are reasonable for a subprocess, it does so. The PID of the process is returned so Auto-GPT can kill it later if it wants, or if the user asks. In my use cases it was smart enough to save the PIDs to a file and name them to remember for later.This will encourage it to use more CPU cores for tasks that could otherwise take a while, and help it avoid bottlenecking on anything but API calls. It is of course in theory capable of achieving this with existing commands, but it doesn't. If it were that smart, we would only have needed a single command for it to be able to run python code and it could build its own instruction set. It seems to need these "available command" hints.
Documentation
It is documented as well as the other commands, and Auto-GPT figures it out.
Test Plan
Before and after this dev:
PR Quality Checklist
Additional Thoughts
Is Popen the best solution? It's just what GPT4 recommended when I asked ChatGPT4 how to address this problem 馃槉