Fix: Update run_continuous.sh to correctly pass all command-line arguments #2012
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Description: - Modified `run_continuous.sh` to include the `--continuous` flag directly in the command: - Removed the unused `argument` variable. - Added the `--continuous` flag to the `./run.sh` command. - Ensured all command-line arguments are passed through to `run.sh` and the `autogpt` module. This change improves the usability of the `run_continuous.sh` script by allowing users to provide additional command-line arguments along with the `--continuous` flag. It ensures that all arguments are properly passed to the `run.sh` script and eventually to the `autogpt` module, preventing confusion and providing more flexible usage. Suggestion from: #1941 (comment)
|
@nponeccop |
Description: Per maintainer's request, removed quotes around `$@` in `run_continuous.sh`. This change allows the script to forward arguments as is. Please note that this modification might cause issues if any of the command-line arguments contain spaces or special characters. However, this update aligns with the preferred format for the repository. Suggestion from: #1941 (comment)
nponeccop
approved these changes
Apr 16, 2023
richbeales
approved these changes
Apr 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
This pull request aims to improve the usability of the
run_continuous.shscript by ensuring that all command-line arguments are passed through to therun.shscript and theautogptmodule. The original implementation did not properly pass additional command-line arguments, which could lead to confusion and limited flexibility for users.Changes
run_continuous.shto include the--continuousflag directly in the command:argumentvariable.--continuousflag to the./run.shcommand.run.shand theautogptmodule.Documentation
The changes made are documented here
Test Plan
run_continuous.shscript on a Linux system with various command-line arguments.--continuousflag was added to the command-line arguments when running the script.run.shscript and theautogptmodule.PR Quality Checklist