Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Driver customization options #2066

Closed
wants to merge 1 commit into from
Closed

Driver customization options #2066

wants to merge 1 commit into from

Conversation

thehunmonkgroup
Copy link

Background

Basically, the way the selenium drivers are set up doesn't allow flexibility for older installs (I'm on Debian 10 headless), or customizing the driver options to work around issues (like my requirement for the --no-sandbox option).

Changes

This adds two new configuration variables:

  • DRIVER_EXECUTABLE_PATH: Allows specifying a custom driver binary.
  • DRIVER_EXTRA_OPTIONS: Allows passing other needed options to the driver.

Documentation

They are clearly documented with comments in .env.template

Test Plan

The changes are quite simple, I didn't do any testing beyond making sure the features work as intended, and that no errors happen when the new configuration options are not used.

PR Quality Checklist

  • My pull request is atomic and focuses on a single change.
  • I have thoroughly tested my changes with multiple different prompts.
  • I have considered potential risks and mitigations for my changes.
  • I have documented my changes clearly and comprehensively.
  • I have not snuck in any "extra" small tweaks changes

@Wetiqe Wetiqe mentioned this pull request Apr 17, 2023
5 tasks
@nponeccop
Copy link
Contributor

@thehunmonkgroup There are conflicts now

@github-actions github-actions bot added the conflicts Automatically applied to PRs with merge conflicts label Apr 17, 2023
@github-actions
Copy link
Contributor

This pull request has conflicts with the base branch, please resolve those so we can evaluate the pull request.

1 similar comment
@github-actions
Copy link
Contributor

This pull request has conflicts with the base branch, please resolve those so we can evaluate the pull request.

@github-actions github-actions bot removed the conflicts Automatically applied to PRs with merge conflicts label Apr 17, 2023
@github-actions
Copy link
Contributor

Conflicts have been resolved! 🎉 A maintainer will review the pull request shortly.

nponeccop
nponeccop previously approved these changes Apr 18, 2023
@github-actions github-actions bot added conflicts Automatically applied to PRs with merge conflicts labels Apr 18, 2023
@github-actions
Copy link
Contributor

This pull request has conflicts with the base branch, please resolve those so we can evaluate the pull request.

2 similar comments
@github-actions
Copy link
Contributor

This pull request has conflicts with the base branch, please resolve those so we can evaluate the pull request.

@github-actions
Copy link
Contributor

This pull request has conflicts with the base branch, please resolve those so we can evaluate the pull request.

@BTCompKSU
Copy link

Hello - First comment on GitHub! I've installed Python 3.10 on Linux / Ubuntu with the latest stable release of Auto-GPT. It is working good except for the browse_website command, which is currently throwing the following error:

System: Command browse_website returned: Error: Message: unknown error: Chrome failed to start: crashed.
  (chrome not reachable)
  (The process started from chrome location /usr/bin/google-chrome is no longer running, so ChromeDriver is assuming that Chrome has crashed.)
Stacktrace:
#0 0x7fbd90bfbfe3 <unknown>
#1 0x7fbd9093ad36 <unknown>
#2 0x7fbd90963b20 <unknown>
#3 0x7fbd9095fa9b <unknown>
#4 0x7fbd909a1af7 <unknown>
#5 0x7fbd909a111f <unknown>
#6 0x7fbd90998693 <unknown>
#7 0x7fbd9096b03a <unknown>
#8 0x7fbd9096c17e <unknown>
#9 0x7fbd90bbddbd <unknown>
#10 0x7fbd90bc1c6c <unknown>
#11 0x7fbd90bcb4b0 <unknown>
#12 0x7fbd90bc2d63 <unknown>
#13 0x7fbd90b95c35 <unknown>
#14 0x7fbd90be6138 <unknown>
#15 0x7fbd90be62c7 <unknown>
#16 0x7fbd90bf4093 <unknown>
#17 0x7fbd904b5609 <unknown>

It sounds like this branch might resolve the issue, but I figured I'd add my two cents just in case it's helpful!

@github-actions github-actions bot removed the conflicts Automatically applied to PRs with merge conflicts label Apr 19, 2023
@github-actions
Copy link
Contributor

Conflicts have been resolved! 🎉 A maintainer will review the pull request shortly.

@thehunmonkgroup
Copy link
Author

Can we get this in? It's a simple patch that I've had to fix conflicts on several times, would really like to close this sucker out.

@probonopd probonopd mentioned this pull request Apr 23, 2023
1 task
@github-actions github-actions bot added the conflicts Automatically applied to PRs with merge conflicts label Apr 24, 2023
@github-actions
Copy link
Contributor

This pull request has conflicts with the base branch, please resolve those so we can evaluate the pull request.

@superherointj
Copy link
Contributor

@thehunmonkgroup Please, fix conflict. Squash (to a single commit) and rebase to master.

@github-actions github-actions bot removed the conflicts Automatically applied to PRs with merge conflicts label Apr 25, 2023
@github-actions
Copy link
Contributor

Conflicts have been resolved! 🎉 A maintainer will review the pull request shortly.

@thehunmonkgroup
Copy link
Author

Done. I really hope you guys get this in now, this is the fourth time I've fixed merge conflicts, probably not gonna do any more of that.

superherointj
superherointj previously approved these changes Apr 26, 2023
@github-actions github-actions bot added the conflicts Automatically applied to PRs with merge conflicts label Apr 27, 2023
@github-actions
Copy link
Contributor

This pull request has conflicts with the base branch, please resolve those so we can evaluate the pull request.

@vercel
Copy link

vercel bot commented Apr 28, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
docs ⬜️ Ignored (Inspect) Apr 28, 2023 3:46am

@github-actions
Copy link
Contributor

Conflicts have been resolved! 🎉 A maintainer will review the pull request shortly.

@github-actions github-actions bot removed the conflicts Automatically applied to PRs with merge conflicts label Apr 28, 2023
@thehunmonkgroup
Copy link
Author

At this point, I have to be approaching the most times anyone has resolved a conflict on a PR for this project, right??

@p-i-
Copy link
Contributor

p-i- commented May 5, 2023

This is a mass message from the AutoGPT core team.
Our apologies for the ongoing delay in processing PRs.
This is because we are re-architecting the AutoGPT core!

For more details (and for infor on joining our Discord), please refer to:
https://github.com/Significant-Gravitas/Auto-GPT/wiki/Architecting

@Boostrix
Copy link
Contributor

Boostrix commented May 7, 2023

At this point, I have to be approaching the most times anyone has resolved a conflict on a PR for this project, right??

Note this looks like a useful change to be reviewed/integrated despite the ongoing re-arch effort, it's primarily config-level, with very few code changes (and those primarily are about adding selenium options for people on older systems). So definitely do consider for review/integration to help close some PRs. Thanks

@anonhostpi
Copy link

I don't agree with merging right now.

#1988 (comment)

@p-i- p-i- removed the B8 label May 16, 2023
@github-actions github-actions bot added the conflicts Automatically applied to PRs with merge conflicts label May 25, 2023
@github-actions
Copy link
Contributor

This pull request has conflicts with the base branch, please resolve those so we can evaluate the pull request.

@thehunmonkgroup
Copy link
Author

Is it worth it to keep updating this PR? Could it still be under consideration? Are y'all done with the big refactor?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
conflicts Automatically applied to PRs with merge conflicts function: browse size/m
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

8 participants