Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix azure config #2355

Merged
merged 3 commits into from
Apr 19, 2023
Merged

Conversation

yunzheng1112
Copy link
Contributor

@yunzheng1112 yunzheng1112 commented Apr 18, 2023

Background

Changes

Documentation

Test Plan

PR Quality Checklist

  • My pull request is atomic and focuses on a single change.
  • I have thoroughly tested my changes with multiple different prompts.
  • I have considered potential risks and mitigations for my changes.
  • I have documented my changes clearly and comprehensively.
  • I have not snuck in any "extra" small tweaks changes

@yunzheng1112
Copy link
Contributor Author

I'm trying to use AutoGPT in my Windows machine with Azure OpenAI resource, and found there are 3 issues:

  1. azure-api-type should be "azure" instead of "azure-ad";
  2. Azure config file location is incorrect;
  3. Completion API call is invalid because of the wrong parameter name;
    Fix them and it works.

fatmelon
fatmelon previously approved these changes Apr 18, 2023
@k-boikov
Copy link
Contributor

Partially duplicate of #2214

@sweetlilmre
Copy link
Contributor

@yunzheng1112

I'm trying to use AutoGPT in my Windows machine with Azure OpenAI resource, and found there are 3 issues:

1. azure-api-type should be "azure" instead of "azure-ad";

2. Azure config file location is incorrect;

3. Completion API call is invalid because of the wrong parameter name;
   Fix them and it works.
  1. I think exposing azure-api-type is redundant, this shouldn't have been hoisted into config in the first place.
  2. 100%
  3. deployment_id works and is according to the documentation. Where do you see that it should be engine? (it is engine for the embedding call) see the docs linked in the README.md

@yunzheng1112
Copy link
Contributor Author

@yunzheng1112

I'm trying to use AutoGPT in my Windows machine with Azure OpenAI resource, and found there are 3 issues:

1. azure-api-type should be "azure" instead of "azure-ad";

2. Azure config file location is incorrect;

3. Completion API call is invalid because of the wrong parameter name;
   Fix them and it works.
  1. I think exposing azure-api-type is redundant, this shouldn't have been hoisted into config in the first place.
  2. 100%
  3. deployment_id works and is according to the documentation. Where do you see that it should be engine? (it is engine for the embedding call) see the docs linked in the README.md

The Completion example in this doc shows it should be "engine":
https://learn.microsoft.com/en-us/azure/cognitive-services/openai/how-to/chatgpt?pivots=programming-language-chat-completions

@yunzheng1112 yunzheng1112 mentioned this pull request Apr 19, 2023
5 tasks
nponeccop
nponeccop previously approved these changes Apr 19, 2023
azure.yaml.template Outdated Show resolved Hide resolved
autogpt/llm_utils.py Outdated Show resolved Hide resolved
@nponeccop nponeccop added bug Something isn't working B8 labels Apr 19, 2023
@Pwuts Pwuts mentioned this pull request Apr 19, 2023
5 tasks
autogpt/llm_utils.py Outdated Show resolved Hide resolved
Pwuts
Pwuts previously approved these changes Apr 19, 2023
@Pwuts Pwuts self-requested a review April 19, 2023 14:54
@Pwuts Pwuts dismissed their stale review April 19, 2023 14:54

Need to check engine vs deployment_id

@Pwuts Pwuts dismissed stale reviews from nponeccop and fatmelon via 45f490e April 19, 2023 15:21
@Pwuts Pwuts merged commit 0d7ab41 into Significant-Gravitas:master Apr 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants