Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add non-essential warning for contributors #2359

Merged
merged 2 commits into from
Apr 18, 2023
Merged

Add non-essential warning for contributors #2359

merged 2 commits into from
Apr 18, 2023

Conversation

sadmuphin
Copy link
Contributor

Background

Provides warning to contributors on PRs that add non-essential commands.

Changes

Adds information to PULL_REQUEST_TEMPLATE.md and CONTRIBUTING.md

PR Quality Checklist

  • My pull request is atomic and focuses on a single change.
  • I have thoroughly tested my changes with multiple different prompts.
  • I have considered potential risks and mitigations for my changes.
  • I have documented my changes clearly and comprehensively.
  • I have not snuck in any "extra" small tweaks changes

Pwuts
Pwuts reviewed Apr 18, 2023
View reviewed changes
CONTRIBUTING.md Outdated Show resolved Hide resolved
.github/PULL_REQUEST_TEMPLATE.md Outdated Show resolved Hide resolved
@Pwuts Pwuts merged commit fbdf9d4 into Significant-Gravitas:master Apr 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pwuts Pwuts Pwuts approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sadmuphin @Pwuts