Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make MacOS TTS voices configurable. #3566

Conversation

dayofthedave
Copy link

@dayofthedave dayofthedave commented Apr 30, 2023

Background

As a MacOS user, I want to be able to choose my preferred voices easily. Making the voices configurable in .env makes it easy to choose voices without have to edit code.

Changes

Added support for 3 new config variables, one for each voice option. If no voice is specified in .env, Auto-GPT will default to Allison, Ava and Samantha, which are all voices that are commonly preinstalled with MacOS, as far as I know. If the default voice specified by Auto-GPT is not installed, MacOS should default to whatever voice is set in System Settings.

Documentation

The new code is easy to understand without documentation.

Test Plan

I ran through several different scenarios with speech enabled. Note that I did not test every possible voice.

PR Quality Checklist

  • My pull request is atomic and focuses on a single change.
  • I have thoroughly tested my changes with multiple different prompts.
  • I have considered potential risks and mitigations for my changes.
  • I have documented my changes clearly and comprehensively.
  • I have not snuck in any "extra" small tweaks changes

@vercel
Copy link

vercel bot commented Apr 30, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 5, 2023 10:28pm

@p-i-
Copy link
Contributor

p-i- commented May 5, 2023

This is a mass message from the AutoGPT core team.
Our apologies for the ongoing delay in processing PRs.
This is because we are re-architecting the AutoGPT core!

For more details (and for infor on joining our Discord), please refer to:
https://github.com/Significant-Gravitas/Auto-GPT/wiki/Architecting

@vercel vercel bot temporarily deployed to Preview May 6, 2023 05:10 Inactive
@vercel vercel bot temporarily deployed to Preview May 7, 2023 02:42 Inactive
@vercel vercel bot temporarily deployed to Preview May 12, 2023 14:35 Inactive
Copy link
Contributor

@gravelBridge gravelBridge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should also modify the .env.template file to accommodate these new variables.

@gravelBridge gravelBridge added the enhancement New feature or request label May 17, 2023
@gravelBridge gravelBridge self-assigned this May 17, 2023
@vercel vercel bot temporarily deployed to Preview June 5, 2023 22:28 Inactive
@Auto-GPT-Bot
Copy link
Contributor

You changed AutoGPT's behaviour. The cassettes have been updated and will be merged to the submodule when this Pull Request gets merged.

@codecov
Copy link

codecov bot commented Jun 5, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.11 🎉

Comparison is base (60ac0c4) 69.58% compared to head (9dadb04) 69.69%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3566      +/-   ##
==========================================
+ Coverage   69.58%   69.69%   +0.11%     
==========================================
  Files          72       72              
  Lines        3551     3554       +3     
  Branches      569      569              
==========================================
+ Hits         2471     2477       +6     
+ Misses        889      885       -4     
- Partials      191      192       +1     
Impacted Files Coverage Δ
autogpt/speech/macos_tts.py 33.33% <0.00%> (-8.34%) ⬇️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@netlify
Copy link

netlify bot commented Jun 17, 2023

Deploy Preview for auto-gpt-docs ready!

Name Link
🔨 Latest commit 157eecb
🔍 Latest deploy log https://app.netlify.com/sites/auto-gpt-docs/deploys/648db7c5c5a323000821321d
😎 Deploy Preview https://deploy-preview-3566--auto-gpt-docs.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@Auto-GPT-Bot
Copy link
Contributor

You changed AutoGPT's behaviour. The cassettes have been updated and will be merged to the submodule when this Pull Request gets merged.

@dayofthedave dayofthedave deleted the improve_macos_speech branch June 17, 2023 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

4 participants