Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposed Configuration ABC #3805

Conversation

dwrtz
Copy link
Contributor

@dwrtz dwrtz commented May 4, 2023

Background

Initial proposal for the abstract base class for the Configuration subsystem. Part of re-arch #3717. Discussion thread on discord. Looking for feedback

Changes

  • added accessors for other subsystem configs. open to suggestions for different name ideas.
  • added set_defaults abstract method.
    The expected use would be something like
agent_system_classes = [
    Workspace,
    PluginManager,
    Planner,
    ...
]

configuration.set_defaults(agent_system_classes)

A concrete implementation can choose a container (a dict) for example. Ideally the implementation defines something like a TypedDict for the return types of the accessors (or something static analysis-friendly).

Documentation

Open to suggestions on this...

@vercel
Copy link

vercel bot commented May 4, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
docs ⬜️ Ignored (Inspect) May 4, 2023 9:51pm

@github-actions github-actions bot added the size/m label May 4, 2023
@dwrtz dwrtz marked this pull request as ready for review May 5, 2023 02:22
@collijk collijk merged commit 516e950 into Significant-Gravitas:agent-state-encapsulation May 5, 2023
4 checks passed
@p-i- p-i- added the re-arch label May 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants