Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

re-arch: Initial BudgetManager impl #3919

Merged
merged 5 commits into from
May 7, 2023

Conversation

richbeales
Copy link
Contributor

@richbeales richbeales commented May 6, 2023

Background

Provides an initial basic implementation of the Budget / Constraint Manager for the re-architecture project. No-one had picked this up so I've given a draft. To be discussed/finessed before merging.

Changes

Flesh out the stub for BudgetManager.

Documentation

Not yet.

Test Plan

PR Quality Checklist

  • My pull request is atomic and focuses on a single change.
  • I have thoroughly tested my changes with multiple different prompts.
  • I have considered potential risks and mitigations for my changes.
  • I have documented my changes clearly and comprehensively.
  • I have not snuck in any "extra" small tweaks changes

@vercel
Copy link

vercel bot commented May 6, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
docs ⬜️ Ignored (Inspect) May 7, 2023 7:01pm

@github-actions github-actions bot added the size/m label May 6, 2023
@Boostrix Boostrix mentioned this pull request May 6, 2023
1 task
@richbeales richbeales marked this pull request as draft May 6, 2023 20:25
@Boostrix
Copy link
Contributor

Boostrix commented May 7, 2023

FWIW, the generated prompt itself would probably also qualify as falling under "constraints", not in the financial/API sense, but in the token/chunking sense - and one that is different for people depending on the level of GPT access they've got ?

If the LLM were to be informed about the estimated costs of certain actions/commands, this could be internally used to benchmark/adapt as needed, i.e. favor actions/commands with less costs involved.

Here's a more detailed description of the idea:

@collijk collijk changed the base branch from agent-state-encapsulation-broken to agent-state-encapsulation May 7, 2023 18:06
@github-actions github-actions bot added the conflicts Automatically applied to PRs with merge conflicts label May 7, 2023
@github-actions
Copy link

github-actions bot commented May 7, 2023

This pull request has conflicts with the base branch, please resolve those so we can evaluate the pull request.

@github-actions github-actions bot added size/l and removed size/m labels May 7, 2023
@richbeales richbeales marked this pull request as ready for review May 7, 2023 18:57
@github-actions
Copy link

github-actions bot commented May 7, 2023

Conflicts have been resolved! 🎉 A maintainer will review the pull request shortly.

@github-actions github-actions bot removed the conflicts Automatically applied to PRs with merge conflicts label May 7, 2023
@collijk collijk merged commit b203de7 into agent-state-encapsulation May 7, 2023
4 checks passed
@collijk collijk deleted the richbeales-patch-3 branch May 7, 2023 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants