Update Wiki to reflect changes with `docker-compose` #4471

kerta1n · 2023-05-29T21:27:47Z

Background

Updated Docker section of wiki

Changes

docker compose is now built-in to the docker command. Previously, docker-compose was an additional binary that the user needed to download, but this is not the case anymore for users that keep their installations up to date.

Documentation

Refer to docs/setup.md

Test Plan

N/A

PR Quality Checklist

My pull request is atomic and focuses on a single change.
~~I have thoroughly tested my changes with multiple different prompts.~~
I have considered potential risks and mitigations for my changes.
I have documented my changes clearly and comprehensively.
I have not snuck in any "extra" small tweaks changes.

~~I have run the following commands against my code to ensure it passes our linters:~~

black .
isort .
mypy
autoflake --remove-all-unused-imports --recursive --ignore-init-module-imports autogpt tests --in-place

Tested that the docker-compose command does not register in terminal anymore

✔

name change to compose.yml

name change to support Docker's documentations

Change "docker-compose" command to "docker compose" to avoid future issues with running the Docker method (`docker-compose` is v1 and is outdated, is not a recognized command with newer versions of Docker engine)

codecov · 2023-05-29T21:33:34Z

Codecov Report

Patch coverage has no change and project coverage change: +20.57 🎉

Comparison is base (2fcd91b) 50.05% compared to head (2eb9560) 70.62%.

❗ Current head 2eb9560 differs from pull request most recent head 1715dc3. Consider uploading reports for the commit 1715dc3 to get more accurate results

Additional details and impacted files

@@             Coverage Diff             @@
##           master    #4471       +/-   ##
===========================================
+ Coverage   50.05%   70.62%   +20.57%     
===========================================
  Files         116       69       -47     
  Lines        4799     3387     -1412     
  Branches      643      554       -89     
===========================================
- Hits         2402     2392       -10     
+ Misses       2218      811     -1407     
- Partials      179      184        +5

see 52 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Boostrix · 2023-06-03T09:38:39Z

thanks for working on this and for updating things !!

kerta1n · 2023-06-03T14:54:57Z

thanks for working on this and for updating things !!

👍👍

Pwuts · 2023-06-04T15:35:42Z

Some quick googling gave the following findings:

Compose v2 as integrated in the docker client was released on 26 April 2022
The final release of Compose v1 was on 10 May 2021
- Compose v1 will no longer be shipped with Docker Desktop after June 2023
This PR replaces references and usage of v1 with v2

If the above is correct, I want to merge this PR ASAP.

Pwuts

Thanks for submitting! Please also update docs/usage.md (lines 14 through 18), and I suggest reverting the rename of docker-compose.yml to compose.yml.

compose.yml

github-actions · 2023-06-05T15:09:06Z

This pull request has conflicts with the base branch, please resolve those so we can evaluate the pull request.

vercel · 2023-06-07T04:38:53Z

Deployment failed with the following error:

Resource is limited - try again in 9 hours (more than 100, code: "api-deployments-free-per-day").

github-actions · 2023-06-07T04:39:07Z

Conflicts have been resolved! 🎉 A maintainer will review the pull request shortly.

vercel · 2023-06-07T05:35:39Z

Deployment failed with the following error:

Resource is limited - try again in 8 hours (more than 100, code: "api-deployments-free-per-day").

Auto-GPT-Bot · 2023-06-13T19:23:37Z

You changed AutoGPT's behaviour. The cassettes have been updated and will be merged to the submodule when this Pull Request gets merged.

Pwuts · 2023-06-13T22:02:43Z

Waiting on checks to complete, but my fork now has docker-compose.yml instead of compose.yml so it should be sufficient to merge.

Well...

As mentioned in previous review: please also update docs/usage.md (lines 14 through 18)

lc0rp · 2023-06-21T08:44:39Z

As mentioned in previous review: please also update docs/usage.md (lines 14 through 18)

@kerta1n bump

Auto-GPT-Bot · 2023-06-21T08:47:42Z

You changed AutoGPT's behaviour. The cassettes have been updated and will be merged to the submodule when this Pull Request gets merged.

kerta1n · 2023-06-21T14:48:31Z

So sorry for not updating this earlier 😭, this should be correct

Auto-GPT-Bot · 2023-06-21T14:49:51Z

You changed AutoGPT's behaviour. The cassettes have been updated and will be merged to the submodule when this Pull Request gets merged.

docker-compose.yml

Auto-GPT-Bot · 2023-06-25T19:26:28Z

You changed AutoGPT's behaviour. The cassettes have been updated and will be merged to the submodule when this Pull Request gets merged.

kerta1n · 2023-06-25T20:56:43Z

As mentioned in previous review: please also update docs/usage.md (lines 14 through 18)

Ready to be resolved

lc0rp · 2023-07-03T19:19:17Z

LGTM

kerta1n · 2023-07-07T01:48:15Z

Small change, but thanks everyone!!

* Update setup.md Change "docker-compose" command to "docker compose" to avoid future issues with running the Docker method (`docker-compose` is v1 and is outdated, is not a recognized command with newer versions of Docker engine) * Update usage.md * Update comment in docker-compose.yml --------- Co-authored-by: Reinier van der Leer <github@pwuts.nl>

kerta1n added 3 commits May 29, 2023 17:09

Delete docker-compose.yml

e946131

name change to compose.yml

Create compose.yml

99d8fbf

name change to support Docker's documentations

Update setup.md

b993d6f

Change "docker-compose" command to "docker compose" to avoid future issues with running the Docker method (`docker-compose` is v1 and is outdated, is not a recognized command with newer versions of Docker engine)

github-actions bot added the size/m label May 29, 2023

Boostrix requested a review from kinance June 3, 2023 09:38

Pwuts added this to the v0.4.1 Release milestone Jun 4, 2023

Pwuts added documentation Improvements or additions to documentation needs discussion To be discussed among maintainers docker labels Jun 4, 2023

Pwuts self-assigned this Jun 4, 2023

Pwuts removed the needs discussion To be discussed among maintainers label Jun 4, 2023

Pwuts requested changes Jun 4, 2023

View reviewed changes

compose.yml Outdated Show resolved Hide resolved

github-actions bot added the conflicts Automatically applied to PRs with merge conflicts label Jun 5, 2023

Rename compose.yml to docker-compose.yml

cd5f29a

github-actions bot removed the conflicts Automatically applied to PRs with merge conflicts label Jun 7, 2023

ntindle and others added 3 commits June 6, 2023 23:40

Update setup.md

1eafdff

Update setup.md

ac91942

Merge branch 'master' into master

c9a7852

ntindle requested a review from Pwuts June 7, 2023 04:43

ntindle added 2 commits June 7, 2023 00:14

Merge branch 'master' into master

1487f1b

Merge branch 'master' into master

4febe93

Merge branch 'master' into master

9be8708

Auto-GPT-Bot added the behaviour change label Jun 13, 2023

lc0rp modified the milestones: v0.4.1 Release, v0.4.2 Release Jun 14, 2023

Merge branch 'master' into master

d3bd1d4

Update usage.md

2463509

Merge branch 'master' into master

6c22731

Pwuts reviewed Jun 21, 2023

View reviewed changes

docker-compose.yml Outdated Show resolved Hide resolved

Update docker-compose.yml

9b2131e

ntindle requested a review from Pwuts June 24, 2023 06:05

ntindle and others added 2 commits June 24, 2023 01:05

Merge branch 'master' into master

baac98a

Merge branch 'master' into master

3a9dedf

lc0rp modified the milestones: v0.4.3 Release, v0.4.4 Release Jun 26, 2023

kerta1n and others added 2 commits June 28, 2023 12:20

Merge branch 'master' into master

1e77a56

Merge branch 'master' into master

2eb9560

lc0rp removed the request for review from kinance July 3, 2023 19:16

Merge branch 'master' into master

1715dc3

Pwuts approved these changes Jul 6, 2023

View reviewed changes

Pwuts merged commit e088295 into Significant-Gravitas:master Jul 6, 2023
14 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update Wiki to reflect changes with `docker-compose` #4471

Update Wiki to reflect changes with `docker-compose` #4471

kerta1n commented May 29, 2023 •

edited by Pwuts

codecov bot commented May 29, 2023 •

edited

Boostrix commented Jun 3, 2023

kerta1n commented Jun 3, 2023

Pwuts commented Jun 4, 2023

Pwuts left a comment

github-actions bot commented Jun 5, 2023

vercel bot commented Jun 7, 2023

github-actions bot commented Jun 7, 2023

vercel bot commented Jun 7, 2023

Auto-GPT-Bot commented Jun 13, 2023

Pwuts commented Jun 13, 2023

lc0rp commented Jun 21, 2023

Auto-GPT-Bot commented Jun 21, 2023

kerta1n commented Jun 21, 2023

Auto-GPT-Bot commented Jun 21, 2023

Auto-GPT-Bot commented Jun 25, 2023

kerta1n commented Jun 25, 2023

lc0rp commented Jul 3, 2023

kerta1n commented Jul 7, 2023

Update Wiki to reflect changes with docker-compose #4471

Update Wiki to reflect changes with docker-compose #4471

Conversation

kerta1n commented May 29, 2023 • edited by Pwuts

Background

Changes

Documentation

Test Plan

PR Quality Checklist

codecov bot commented May 29, 2023 • edited

Codecov Report

Boostrix commented Jun 3, 2023

kerta1n commented Jun 3, 2023

Pwuts commented Jun 4, 2023

Pwuts left a comment

Choose a reason for hiding this comment

github-actions bot commented Jun 5, 2023

vercel bot commented Jun 7, 2023

github-actions bot commented Jun 7, 2023

vercel bot commented Jun 7, 2023

Auto-GPT-Bot commented Jun 13, 2023

Pwuts commented Jun 13, 2023

lc0rp commented Jun 21, 2023

Auto-GPT-Bot commented Jun 21, 2023

kerta1n commented Jun 21, 2023

Auto-GPT-Bot commented Jun 21, 2023

Auto-GPT-Bot commented Jun 25, 2023

kerta1n commented Jun 25, 2023

lc0rp commented Jul 3, 2023

kerta1n commented Jul 7, 2023

Update Wiki to reflect changes with `docker-compose` #4471

Update Wiki to reflect changes with `docker-compose` #4471

kerta1n commented May 29, 2023 •

edited by Pwuts

codecov bot commented May 29, 2023 •

edited