Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add challenge identifiers to pytest #4661

Conversation

waynehamadi
Copy link
Contributor

@waynehamadi waynehamadi commented Jun 11, 2023

Background

When downloading logs from benchmarks.yml and ci.yml, we don't know the challenge being run.

Changes

  • added challenge name and level to logs
  • added back the fix for selenium tests
  • removed whitespaces from summarize_batch method

Documentation

Test Plan

PR Quality Checklist

  • My pull request is atomic and focuses on a single change.
  • I have thoroughly tested my changes with multiple different prompts.
  • I have considered potential risks and mitigations for my changes.
  • I have documented my changes clearly and comprehensively.
  • I have not snuck in any "extra" small tweaks changes.
  • I have run the following commands against my code to ensure it passes our linters:
    black .
    isort .
    mypy
    autoflake --remove-all-unused-imports --recursive --ignore-init-module-imports --ignore-pass-after-docstring autogpt tests --in-place

@vercel
Copy link

vercel bot commented Jun 11, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
docs ⬜️ Ignored (Inspect) Jun 12, 2023 2:52pm

@netlify
Copy link

netlify bot commented Jun 11, 2023

Deploy Preview for auto-gpt-docs canceled.

Name Link
🔨 Latest commit 9155e16
🔍 Latest deploy log https://app.netlify.com/sites/auto-gpt-docs/deploys/6487311cfd32a1000896b022

@waynehamadi waynehamadi force-pushed the add-challenge-indentifiers-to-pytest branch from 246c9ef to 5afabbc Compare June 11, 2023 23:25
@codecov
Copy link

codecov bot commented Jun 11, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.04 ⚠️

Comparison is base (a9d177e) 69.96% compared to head (9155e16) 69.92%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4661      +/-   ##
==========================================
- Coverage   69.96%   69.92%   -0.04%     
==========================================
  Files          72       72              
  Lines        3586     3588       +2     
  Branches      569      569              
==========================================
  Hits         2509     2509              
- Misses        894      895       +1     
- Partials      183      184       +1     
Impacted Files Coverage Δ
autogpt/log_cycle/log_cycle.py 95.65% <100.00%> (+0.19%) ⬆️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@waynehamadi waynehamadi merged commit d5afbbe into Significant-Gravitas:master Jun 12, 2023
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants