Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Benchmarks write cassettes without using them #4664

Conversation

waynehamadi
Copy link
Contributor

@waynehamadi waynehamadi commented Jun 12, 2023

Background

Benchmarks retry tests once if they fail. If they use cassettes, the second test is doomed to fail as well.

Changes

  • add --record-mode=all to benchmarks.yml so that we record interactions but without replaying them

Documentation

Test Plan

PR Quality Checklist

  • My pull request is atomic and focuses on a single change.
  • I have thoroughly tested my changes with multiple different prompts.
  • I have considered potential risks and mitigations for my changes.
  • I have documented my changes clearly and comprehensively.
  • I have not snuck in any "extra" small tweaks changes.
  • I have run the following commands against my code to ensure it passes our linters:
    black .
    isort .
    mypy
    autoflake --remove-all-unused-imports --recursive --ignore-init-module-imports --ignore-pass-after-docstring autogpt tests --in-place

@vercel
Copy link

vercel bot commented Jun 12, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
docs ⬜️ Ignored (Inspect) Jun 12, 2023 0:48am

@waynehamadi waynehamadi marked this pull request as draft June 12, 2023 00:42
@netlify
Copy link

netlify bot commented Jun 12, 2023

Deploy Preview for auto-gpt-docs canceled.

Name Link
🔨 Latest commit 7214b2e
🔍 Latest deploy log https://app.netlify.com/sites/auto-gpt-docs/deploys/6488b1d0c487420008f61736

@waynehamadi waynehamadi force-pushed the benchmarks-shouldnt-use-cassettes branch from 6dbdced to da3ff8f Compare June 12, 2023 00:48
@codecov
Copy link

codecov bot commented Jun 12, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.20 🎉

Comparison is base (07d9b58) 70.43% compared to head (7214b2e) 70.64%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4664      +/-   ##
==========================================
+ Coverage   70.43%   70.64%   +0.20%     
==========================================
  Files          70       70              
  Lines        3437     3437              
  Branches      547      547              
==========================================
+ Hits         2421     2428       +7     
+ Misses        848      837      -11     
- Partials      168      172       +4     

see 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@github-actions github-actions bot added the conflicts Automatically applied to PRs with merge conflicts label Jun 12, 2023
@github-actions
Copy link

This pull request has conflicts with the base branch, please resolve those so we can evaluate the pull request.

@waynehamadi waynehamadi force-pushed the benchmarks-shouldnt-use-cassettes branch from da3ff8f to 7214b2e Compare June 13, 2023 18:13
@github-actions github-actions bot removed the conflicts Automatically applied to PRs with merge conflicts label Jun 13, 2023
@github-actions
Copy link

Conflicts have been resolved! 🎉 A maintainer will review the pull request shortly.

@github-actions github-actions bot added size/m and removed size/l labels Jun 13, 2023
@waynehamadi waynehamadi marked this pull request as ready for review June 13, 2023 18:15
@Auto-GPT-Bot
Copy link
Contributor

You changed AutoGPT's behaviour. The cassettes have been updated and will be merged to the submodule when this Pull Request gets merged.

Copy link
Contributor

@dschonholtz dschonholtz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay run more tests from scratch. use cassettes less. get more data

@waynehamadi waynehamadi merged commit 3df8c1b into Significant-Gravitas:master Jun 13, 2023
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants