Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix up Python execution commands #4756

Merged
merged 5 commits into from Jun 21, 2023

Conversation

Wladastic
Copy link
Contributor

@Wladastic Wladastic commented Jun 20, 2023

Background

Changes

Documentation

Test Plan

PR Quality Checklist

  • My pull request is atomic and focuses on a single change.
  • I have thoroughly tested my changes with multiple different prompts.
  • I have considered potential risks and mitigations for my changes.
  • I have documented my changes clearly and comprehensively.
  • I have not snuck in any "extra" small tweaks changes.
  • I have run the following commands against my code to ensure it passes our linters:
    black .
    isort .
    mypy
    autoflake --remove-all-unused-imports --recursive --ignore-init-module-imports --ignore-pass-after-docstring autogpt tests --in-place

@netlify
Copy link

netlify bot commented Jun 20, 2023

Deploy Preview for auto-gpt-docs canceled.

Name Link
🔨 Latest commit 72e1c0e
🔍 Latest deploy log https://app.netlify.com/sites/auto-gpt-docs/deploys/649324dd39c92200082462ae

@erik-megarad
Copy link
Contributor

test is failing. also we probably want to add a test to ensure that it is restricted to the workspace.

@github-actions github-actions bot added size/m and removed size/s labels Jun 20, 2023
Pwuts
Pwuts previously requested changes Jun 21, 2023
autogpt/commands/execute_code.py Outdated Show resolved Hide resolved
tests/integration/test_execute_code.py Outdated Show resolved Hide resolved
tests/integration/test_execute_code.py Outdated Show resolved Hide resolved
@Pwuts Pwuts changed the title fix rce on execute_python_code Fix up Python execution commands Jun 21, 2023
@Pwuts Pwuts added this to the v0.4.3 Release milestone Jun 21, 2023
@Pwuts Pwuts dismissed their stale review June 21, 2023 16:26

addressed

@codecov
Copy link

codecov bot commented Jun 21, 2023

Codecov Report

Patch coverage: 92.85% and no project coverage change.

Comparison is base (4e3f832) 70.63% compared to head (72e1c0e) 70.63%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4756   +/-   ##
=======================================
  Coverage   70.63%   70.63%           
=======================================
  Files          67       67           
  Lines        3238     3239    +1     
  Branches      513      514    +1     
=======================================
+ Hits         2287     2288    +1     
  Misses        783      783           
  Partials      168      168           
Impacted Files Coverage Δ
autogpt/commands/execute_code.py 71.56% <92.30%> (+0.28%) ⬆️
autogpt/json_utils/utilities.py 74.28% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Pwuts Pwuts self-assigned this Jun 21, 2023
@erik-megarad erik-megarad merged commit 32038c9 into Significant-Gravitas:master Jun 21, 2023
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants