Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move more app files to app package #5036

Merged
merged 9 commits into from Aug 1, 2023
Merged

Conversation

collijk
Copy link
Contributor

@collijk collijk commented Jul 21, 2023

Background

We moved a bunch of application files to an application subpackage in #5026. This continues on that path.

Changes

  • autogpt.spinner.py -> autogpt.app.spinner.py
  • autogpt.utils.batch -> autogpt.processing.text.batch
  • autogpt.utils.clean_input -> autogpt.app.utils.clean_input
  • Remove unused autogpt.utils.readable_file_size
  • autogpt.utils.clean_input -> autogpt.app.utils.clean_input
  • autogpt.utils.get_bulletin_from_web -> autogpt.app.utils.get_bulletin_from_web
  • autogpt.utils.get_current_git_branch -> autogpt.app.utils.get_current_git_branch
  • autogpt.utils.get_latest_bulletin -> autogpt.app.utils.get_latest_bulletin
  • autogpt.utils.markdown_to_ansi_style -> autogpt.app.utils.markdown_to_ansi_style
  • autogpt.utils.get_legal_warning -> autogpt.app.utils.get_legal_warning

Documentation

X

Test Plan

CI

PR Quality Checklist

  • My pull request is atomic and focuses on a single change.
  • I have thoroughly tested my changes with multiple different prompts.
  • I have considered potential risks and mitigations for my changes.
  • I have documented my changes clearly and comprehensively.
  • I have not snuck in any "extra" small tweaks changes.
  • I have run the following commands against my code to ensure it passes our linters:
    black .
    isort .
    mypy
    autoflake --remove-all-unused-imports --recursive --ignore-init-module-imports --ignore-pass-after-docstring autogpt tests --in-place

@netlify
Copy link

netlify bot commented Jul 21, 2023

Deploy Preview for auto-gpt-docs failed.

Name Link
🔨 Latest commit 33b44dc
🔍 Latest deploy log https://app.netlify.com/sites/auto-gpt-docs/deploys/64c93e6e19f9ff00086fd8eb

@codecov
Copy link

codecov bot commented Jul 21, 2023

Codecov Report

Patch coverage: 58.13% and project coverage change: -0.04% ⚠️

Comparison is base (7cd407b) 51.95% compared to head (33b44dc) 51.91%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5036      +/-   ##
==========================================
- Coverage   51.95%   51.91%   -0.04%     
==========================================
  Files         116      117       +1     
  Lines        4987     4981       -6     
  Branches      671      669       -2     
==========================================
- Hits         2591     2586       -5     
  Misses       2198     2198              
+ Partials      198      197       -1     
Files Changed Coverage Δ
autogpt/app/spinner.py 97.36% <ø> (ø)
autogpt/processing/text.py 32.72% <20.00%> (-1.24%) ⬇️
autogpt/app/utils.py 58.44% <58.44%> (ø)
autogpt/app/main.py 43.43% <100.00%> (ø)
autogpt/app/setup.py 73.41% <100.00%> (ø)
autogpt/utils.py 100.00% <100.00%> (+37.75%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

ntindle
ntindle previously approved these changes Jul 24, 2023
@lc0rp lc0rp merged commit a593c32 into master Aug 1, 2023
13 of 19 checks passed
@lc0rp lc0rp deleted the refactor/app-isolation-pt-2 branch August 1, 2023 17:48
@lc0rp lc0rp added this to the v0.4.7 Release milestone Aug 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants