Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

slips of the pen (bloopers) in autogpt/core part of the repo #5045

Merged
merged 9 commits into from Aug 1, 2023

Conversation

cyrus-hawk
Copy link
Contributor

@cyrus-hawk cyrus-hawk commented Jul 24, 2023

Background

I'm trying to write some pytests for the core part of the Auto-GPT, I sometimes notice some bloopers along the way. These are subtle mistakes that sometimes elude our eyes.

Changes

I try to fix them with minimum required changes.

Documentation

NA

Test Plan

pytests are written for these changes, to make sure everything is run smoothly.

PR Quality Checklist

  • My pull request is atomic and focuses on a single change.
  • I have thoroughly tested my changes with multiple different prompts.
  • I have considered potential risks and mitigations for my changes.
  • I have documented my changes clearly and comprehensively.
  • I have not snuck in any "extra" small tweaks changes.
  • I have run the following commands against my code to ensure it passes our linters:
    black .
    isort .
    mypy
    autoflake --remove-all-unused-imports --recursive --ignore-init-module-imports --ignore-pass-after-docstring autogpt tests --in-place

@netlify
Copy link

netlify bot commented Jul 24, 2023

Deploy Preview for auto-gpt-docs failed.

Name Link
🔨 Latest commit 70e582a
🔍 Latest deploy log https://app.netlify.com/sites/auto-gpt-docs/deploys/64c92657824b20000706e3b2

collijk
collijk previously approved these changes Jul 24, 2023
@codecov
Copy link

codecov bot commented Jul 24, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.01% ⚠️

Comparison is base (ad18f77) 51.95% compared to head (f83b187) 51.94%.

❗ Current head f83b187 differs from pull request most recent head 70e582a. Consider uploading reports for the commit 70e582a to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5045      +/-   ##
==========================================
- Coverage   51.95%   51.94%   -0.01%     
==========================================
  Files         116      116              
  Lines        4987     4976      -11     
  Branches      671      668       -3     
==========================================
- Hits         2591     2585       -6     
+ Misses       2198     2196       -2     
+ Partials      198      195       -3     
Files Changed Coverage Δ
autogpt/core/ability/base.py 0.00% <0.00%> (ø)
autogpt/core/resource/model_providers/openai.py 0.00% <0.00%> (ø)

... and 6 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cyrus-hawk cyrus-hawk changed the title fix omitted "()" in __str__(self) in core/ability/base.py slips of the pen (bloopers) in autogpt/core part of the repo Jul 25, 2023
@github-actions github-actions bot added size/m and removed size/s labels Jul 31, 2023
@collijk collijk merged commit c8914eb into Significant-Gravitas:master Aug 1, 2023
9 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants