Remove irrelevant noqa comments #905
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
endolith
force-pushed
the
noqa
branch
4 times, most recently
from
53dd7c8
to
36039d2
Compare
nponeccop
previously approved these changes
Apr 13, 2023
|
@endolith There are conflicts now |
|
Made irrelevant by 1073954, but found another one and replaced this branch with that. |
endolith
changed the title
nponeccop
previously approved these changes
Apr 16, 2023
E722 is "Do not use bare except, specify exception instead" but except json.JSONDecodeError is not a bare except
richbeales
approved these changes
Apr 17, 2023
SquareandCompass
pushed a commit
to SquareandCompass/Auto-GPT
that referenced
this pull request
Oct 21, 2023
* add cost budget; move loc of make_dir * support openai completion * install pytest in workflow * skip openai test * test openai * path for docs rebuild * install datasets * signal * notebook * notebook in workflow * optional arguments and special params * key -> k * improve readability * assumption * optimize for model selection * larger range of max_tokens * notebook * python package workflow * skip on win
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
There is a noqa comment on
eeven thougheis used and will not trigger QA. Other lines havenoqawhen it would be better to just not assign to a variable in the first place.Changes
Removed the unused underscore variable assignments and unnecessary comments
Documentation
I removed erroneous comments
Test Plan
I tested it a bit, but I can't conceive of any negative effects. Removing assignment to an unused variable does nothing. Removing an erroneous comment does nothing.
PR Quality Checklist