Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refractoring IInstruction #2

Closed
droni1234 opened this issue Mar 3, 2021 · 1 comment
Closed

Refractoring IInstruction #2

droni1234 opened this issue Mar 3, 2021 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@droni1234
Copy link
Collaborator

droni1234 commented Mar 3, 2021

bool RequiresPosition { get; }

I think we dont need this, its more or less firmly defined for the types

InstructionType Type { get; }
public enum InstructionType
{

    BezireTo, //requiresPosition
    LineTo, //requiresPoistion
    MoveTo, //requiresPosition
    Winding, //noPosition
    Close //noPosition

}

And maybe rename Prepare to Setup

void Prepare(State state);

to

void Setup(State state);
@droni1234 droni1234 added the enhancement New feature or request label Mar 3, 2021
@MatijaBrown
Copy link
Collaborator

I did the changes - any more?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants