-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ZMQ is not properly added to the codebase. Many Errors and missing files. #20
Comments
I've updated the issue with more information. |
To fully implement ZMQ properly so it can actually function there are several or more files added and upgrades that should have been completed first after researching bitcoin's development history. |
The original PR can be found here: #64 I was surprised to see that it passed Travis, but after looking at the Travis output I was even more surprised to see that it somehow did not use the newly changed configure and makefiles. It is very strange. |
Thank you for removing ZMQ, I'll rework the branch and fix it |
Describe the issue
Unless the --disable-zmq is added to your configuration command, the code is broken and the following error is given;
When that include is commented out the following compilation error is given:
make[2]: *** No rule to make target 'libsilk_zmq.a', needed by 'silkd'. Stop.
After fixing that issue I recieved about 20 more compilation errors related to ZMQ files.
I'm not sure how this made it into master to begin with, but it either needs to be completely reverted or fixed.
Steps to reproduce
What platform are you using (Linux, Windows, Mac)
Ubuntu 16
The text was updated successfully, but these errors were encountered: