Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ZMQ is not properly added to the codebase. Many Errors and missing files. #20

Closed
quantumgravity444 opened this issue Dec 6, 2016 · 4 comments

Comments

@quantumgravity444
Copy link
Contributor

quantumgravity444 commented Dec 6, 2016

Describe the issue

Unless the --disable-zmq is added to your configuration command, the code is broken and the following error is given;

In file included from init.cpp:49:0:
zmq/zmqnotificationinterface.h:9:33: fatal error: validationinterface.h: No such file or directory
compilation terminated.

When that include is commented out the following compilation error is given:

make[2]: *** No rule to make target 'libsilk_zmq.a', needed by 'silkd'. Stop.

After fixing that issue I recieved about 20 more compilation errors related to ZMQ files.

I'm not sure how this made it into master to begin with, but it either needs to be completely reverted or fixed.

Steps to reproduce

  1. Follow the normal build instructions.

What platform are you using (Linux, Windows, Mac)

Ubuntu 16

@quantumgravity444 quantumgravity444 changed the title ZMQ is still causing build issues. ZMQ is not properly added to the codebase. Many Errors and missing files. Dec 6, 2016
@quantumgravity444
Copy link
Contributor Author

I've updated the issue with more information.

@quantumgravity444
Copy link
Contributor Author

To fully implement ZMQ properly so it can actually function there are several or more files added and upgrades that should have been completed first after researching bitcoin's development history.

@quantumgravity444
Copy link
Contributor Author

quantumgravity444 commented Dec 6, 2016

The original PR can be found here: #64

I was surprised to see that it passed Travis, but after looking at the Travis output I was even more surprised to see that it somehow did not use the newly changed configure and makefiles. It is very strange.

@ghost
Copy link

ghost commented Dec 8, 2016

Thank you for removing ZMQ, I'll rework the branch and fix it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant