Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breaking Changes 0.36.0 #2

Open
3 tasks
Silvenga opened this issue Aug 9, 2016 · 8 comments
Open
3 tasks

Breaking Changes 0.36.0 #2

Silvenga opened this issue Aug 9, 2016 · 8 comments

Comments

@Silvenga
Copy link
Owner

Silvenga commented Aug 9, 2016

Major changes in the subscription API broke most of this library's core features in the 0.36.0 upgrade.

  • General messaging
  • Subscribing to all rooms
  • Subscribing for room info
@agc93
Copy link

agc93 commented May 16, 2017

Is the plan still to update this library to match the new changes? Rocket.Chat is up to 0.56.0 now, and I'm not sure if the API has changed again (seems likely).

@Silvenga
Copy link
Owner Author

@agc93 see #3. Still waiting. 😺

@moisespr123
Copy link

My bot works just fine with 0.56.0, although I'm just reading and sending messages. Haven't tested anything else.

I do occasionally experience that the bot crashes when the chat is offline.

I tested this by doing a clean install using Ubuntu and Snaps

@Qamaruddin2
Copy link

Hi Silvenga, "Subscription 'subscription' not found [404]" issue has kept me up for the past few days. Then I went to your comments in RocketChat Issue # 142 RocketChat/hubot-rocketchat#142. This helped me resolve this Subscription problem.

It would have been great if you could have updated the code in this Repos.

Just as a reference for others, I am copy-pasting the resolution you provided there ----

What I've experienced:

Subscriptions to stream-messages result in 404's (similar to 0.1.4 behavior).
Subscribing to room information was broken
I upgraded to be inline with 1.0.1 from the Hubot stream branch by
Message type from added to changed
Subscription name changed from stream-messages to stream-room-messages
Use 2nd index of args from the 1st index on the Rocket.Chat messages JSON objects.
Subscribing to all rooms from null to my_messages
Sending true instead of the never used "Message Subscription Limit"
It appears, with these changes, that my library can now receive messages from itself via my_messages and stream-room-messages

Thanks for providing a .Net implementation of RocketChat.

@Silvenga
Copy link
Owner Author

@Qamaruddin2
I don't doubt that things are broken when targeting anything recent. However, I don't want to support Rocket.Chat until there's a documented API, to help my personal sanity (would need https://rocket.chat/docs/developer-guides/realtime-api/ released).

I always welcome pull requests if someone wants to update support. 😸

@nhotoi
Copy link

nhotoi commented Apr 24, 2020

@Silvenga can you update it for me, I need it and have tried to upgrade your project! I was not successful!please help me! thanks you so much

@Silvenga
Copy link
Owner Author

Silvenga commented May 1, 2020

I'm sorry @nhotoi the realtime api was never created.

@antoniozh
Copy link

Hi, I am currently attempting to update your library to the current Realtime API version, but except from logging in, not much seems to be working. Do you know if the realtime API is still not working? I am getting many meteor errors when testing out requests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants