Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Terminate simulation if max number of Newton iterations is reached by default #192

Open
1 task done
mrp089 opened this issue Feb 21, 2024 · 0 comments
Open
1 task done
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@mrp089
Copy link
Member

mrp089 commented Feb 21, 2024

Problem

We currently continue a simulation without an error or warning when the maximum number of Newton iterations is reached. This might wrongly indicate to the user that a time step has converged.

Solution

By default, terminate the solution with an error if running into the maximum number of Newton iterations. Let the user define a flag to continue but still throw a warning every time this happens.

Additional context

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct and Contributing Guidelines
@mrp089 mrp089 added enhancement New feature or request good first issue Good for newcomers labels Feb 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant