Workaround for networked filesystems on Windows (nodejs/node#48530) #174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…systems on Windows
|
Thanks! This must have been annoying to debug 😅 |
github-actions bot
pushed a commit
that referenced
this pull request
Jul 5, 2023
## [1.0.2](v1.0.1...v1.0.2) (2023-07-05) ### Bug Fixes * workaround for networked filesystems on Windows ([#174](#174)) ([4de72ea](4de72ea))
|
Bot hit rate limit commenting on all merged renovate PRs 🙈 https://github.com/SimenB/collect-v8-coverage/releases/tag/v1.0.2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using networked filesystems on Windows, V8 sometimes returns URLs that look like
file:////<host>/path. Given that these URLs are well understood by Python, Windows Explorer and Chrome, this is presumably not a bug in V8. On the other hand, NodeJS does not parse these correctly (nodejs/node#48530) and it ends up throwing instead.