Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Few drawbacks needs to improve #46

Closed
hiteshsarsava opened this issue Dec 27, 2022 · 2 comments · Fixed by #48
Closed

Few drawbacks needs to improve #46

hiteshsarsava opened this issue Dec 27, 2022 · 2 comments · Fixed by #48

Comments

@hiteshsarsava
Copy link

Is your feature request related to a problem? Please describe.

  1. The button should be disable when it is in loading state, There is no meaning of showing progress indicator and user can still able to request the operation on click of button.
  2. There should be no mandatory pass the width and height arguments. What if user wants to set wrap content or fillMaxWidth()(match parent) of button size. This is not proper use case where user needs to calculate the width and height of the button and pass as argument.
  3. There is no modifier argument for button itself.
@ShwetaChauhan18
Copy link
Contributor

Thanks, @hiteshsarsava to draw attention. We will check.

@purvesh-d
Copy link
Collaborator

Replies to above points:

  1. Issue is resolved and PR merged.
  2. Mandatory passing the width and height is requierd because we are using it to animate button height/width while button is in loading state. If there is a way to do that without fixed height/width then please feel free to share.
  3. We are using modifier to to animate button size so if we provide modifier argument then animation will not work when user change size related property.  So to give customisation most of all the properties of modifier we have added in SSJetPackComposeProgressButton argument as mention below.
  • Background/ Colors
  • Padding
  • Border
  • Alpha
  • Click action
    If you want to use more properties of modifier for customisation then please provide us that properties so we can plan to add it in upcoming release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants