New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
version 1.0.0 that the waveform is too uniform #144
Comments
@csacchetti Are we here talking about waveform while recording? If yes then how do you suggest we handle the data because the ios and android send different kind of data. In ios we get We are open to any contribution so if you would like to create a PR to improve this functionality than we are happy to have that. |
Yes I was talking about waveform while recording, sorry. |
In 0.1.5+1, we were just adding normalizationFactor to whatever value we get from native. Now, this wasn't good way to do this because every phone has different microphone system so for some phone the normalizationFactor would work but for others you might get inverted waves because native side is providing with negative Dbs, as you can see in this issue #43. |
Strange, it worked better for me. I set a different normalizationFactor between Android and iOS but it was satisfactory. |
@csacchetti For 1.0.0 release what we have done is that rather then adding or subtracting any value, We normalize it against max and min value. You can check |
Unfortunately I do not yet have the skills to make a change to the plugin. I hoped that putting the option for a behaviour like the previous version would not be a problem for those who have already done so. It remains that Android is acceptable while iOS is too uniform. Patience. |
@csacchetti We will discuss this internally see if we should provide the older version. |
Thanks |
Ok we will be providing a flag soon to use previous version of normalization until we find better way to normalise |
Thanks a lot. |
I ask if there is a possibility with version 1.0.0 that the waveform is not as uniform. The last version before 1.0.0 was more realistic. This one is very normalised and not as precise. Also the scaleFactor increases proportionally in size but still remains very uniform.
Thank you
The text was updated successfully, but these errors were encountered: