Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I try to reproduce the results of your experiment about RMSE. #2

Closed
DavidZhang88 opened this issue Sep 24, 2020 · 3 comments
Closed

Comments

@DavidZhang88
Copy link

DavidZhang88 commented Sep 24, 2020

Dear Zuo,
I hope everything is fine with you, after saw your paper, I am really interested in you work, and learned a lot from it. However, I have a little question, how do you get the so small RMSE? While I get the RMSE on Financal data, is like
Minimum RMSE: xx.xxxxx while in the paper, it is only 0.93.
Are there some hyper-parameters about loss function need to adjustment? I set
loss = 0 * event_loss + 0* pred_loss + se / scale_time_loss
But it still doesn' t work, could you offer me some help?
Thank you.

Sincerely yours,
Luning Zhang

@DavidZhang88
Copy link
Author

The result in your paper, the unit should be minite, and in code is second right? I think I figure it out. Thank you again for the efficient and easy-to-understand code. I learned a lot from it.

@ritvik06
Copy link

It is difficult to reproduce the results without knowing the scale of normalisation of the datasets. Have you been able to reproduce the results given in the paper? If yes, then at what alterations/normalisation did you have to do?

@ritvik06
Copy link

ritvik06 commented Aug 4, 2021

Another issue, as the mark and time prediction loss is added to the log likelihood term as part of our training, one would need to scale these losses to make them comparable.

Although I figured the scale of their normalisation for the RMSE results by referring to the results for the used datasets given in the other paper for eg. RMTPP (Du et al.) and Neural Hawkes Process etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants