Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MdTargetDir .git error #251

Closed
jzabroski opened this issue Jun 21, 2020 · 3 comments
Closed

MdTargetDir .git error #251

jzabroski opened this issue Jun 21, 2020 · 3 comments
Labels
Milestone

Comments

@jzabroski
Copy link

Preamble

Using MarkdownSnippets.MSBuild 18.0.0 or 19.0.0 - same error

Describe the bug

A clear and concise description of what the bug is. Include any relevant version information.
It seems like MarkdownSnippets.MSBuild is not usable when the initial build target is dotnet test.

A clear and concise description of what you expected to happen.
A clearer error message than:

No '.git' directory found. Define a MdTargetDir.

Add any other context about the problem here.
I reviewed the last code change, here: fee9f9b#r40062164

Minimal Repro

Clone RazorLight repo. run the following commands in root directory:

dotnet --info
dotnet restore
dotnet test  tests/RazorLight.Tests/RazorLight.Tests.csproj
@jzabroski
Copy link
Author

The problem seems to be that it assumes you'll always run dotnet test without any csproj argument, and that your solution directory is tightly coupled to your .git directory. Is there a way to configure this? I don't see anything in the readme.

@SimonCropp SimonCropp added this to the 19.0.1 milestone Jun 22, 2020
@SimonCropp SimonCropp added the Bug label Jun 22, 2020
@SimonCropp
Copy link
Owner

can u try 19.0.1

@jzabroski
Copy link
Author

Seems to be fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants