Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove static method DirectoryMarkdownProcessor.RunForFilePath #66

Closed
SimonCropp opened this issue Jul 28, 2019 · 6 comments
Closed

remove static method DirectoryMarkdownProcessor.RunForFilePath #66

SimonCropp opened this issue Jul 28, 2019 · 6 comments
Milestone

Comments

@SimonCropp
Copy link
Owner

use instance API instead

@SimonCropp SimonCropp added this to the 15.0.0 milestone Jul 28, 2019
@SeanFeldman
Copy link

I'm a bit late to update and have a question about this change.
Static API did not require specifying any parameters. Instance API now has a mandatory target directory that cannot be null or empty. What's the expected target directory to ensure unit tests continue working properly?

@SimonCropp
Copy link
Owner Author

What repo r u using it in?

@SeanFeldman
Copy link

I need to use GitRepoDirectoryFinder.FindForFilePath().

When you change APIs similar to this one, would be good to provide a hint of what needs to be used. I couldn't find anything related to this in readme.md and had to scan the tests to find out what would work. Thanks.

@SimonCropp
Copy link
Owner Author

@SimonCropp
Copy link
Owner Author

would be good to provide a hint of what needs to be used.

sounds good. can u submit a docs PR to this page that explains the use of GitRepoDirectoryFinder

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants