Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build failure against binutils-2.39 (init_disassemble_info() API change) #381

Closed
trofi opened this issue Aug 25, 2022 · 2 comments
Closed

Comments

@trofi
Copy link
Contributor

trofi commented Aug 25, 2022

binutils-2.39 slightly changed an API of init_disassemble_info() by adding extra param. Now kcov fils the build as:

kcov> /build/source/src/parsers/bfd-disassembler.cc: In constructor 'BfdDisassembler::BfdDisassembler()':
kcov> /build/source/src/parsers/bfd-disassembler.cc:78:38: error: too few arguments to function 'void init_disassemble_info(disassemble_info*, void*, fprintf_ftype, fprintf_styled_ftype)'
kcov>    78 |                 init_disassemble_info(&m_info, (void *)this, BfdDisassembler::opcodesFprintFuncStatic);
kcov>       |                 ~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

If it helps here is how linux.git dealt with API change: torvalds/linux@00b3262...600b7b2

@SimonKagstrom
Copy link
Owner

Thanks for the report!

I'll think of some way to handle both, although I guess in kcovs case if might be enough with just an #ifdef

@SimonKagstrom
Copy link
Owner

Fixed by @oreo639 , so closing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants