Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve selector_to_xpath tests on pseudo-elements #41

Merged
merged 1 commit into from Oct 18, 2013

Conversation

dangra
Copy link
Member

@dangra dangra commented Oct 17, 2013

This PR addresses this comments d29ac49#commitcomment-4358942

@SimonSapin
Copy link
Contributor

Thanks for contributing. Could you fix Python 2.5 compat and move this to test_pseudo_elements?

@dangra
Copy link
Member Author

dangra commented Oct 18, 2013

let me know if you prefer a solution like this http://stackoverflow.com/questions/11285313/try-except-as-error-in-python-2-5-python-3-x instead of asserting only the exception type.

I will squash into a sigle commit once it passes tests on all platforms.

@SimonSapin
Copy link
Contributor

I think assertRaises is enough, that was in case you wanted to keep testing the message.

Looks good, thanks!

SimonSapin added a commit that referenced this pull request Oct 18, 2013
Improve selector_to_xpath tests on pseudo-elements
@SimonSapin SimonSapin merged commit f7b38ba into scrapy:master Oct 18, 2013
@dangra dangra deleted the tests-for-pseduo-elements branch January 14, 2014 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants