Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gradient Support #119

Closed
varunsridharan opened this issue Jul 14, 2019 · 18 comments
Closed

Gradient Support #119

varunsridharan opened this issue Jul 14, 2019 · 18 comments
Labels
feature request New feature requested wontfix This will not be worked on

Comments

@varunsridharan
Copy link

Do you want to request a feature or report a bug?

Feature Request

Do you have any idea for adding gradient support ? if so when it could be ?

Example

image

http://tutsville.com/docs/coloringpick-jquery-gradient-color-picker/

@simonwep simonwep changed the title [Feature Request] -- Gradient Support Gradient Support Jul 14, 2019
@simonwep simonwep added feature request New feature requested wontfix This will not be worked on labels Jul 14, 2019
@simonwep
Copy link
Owner

simonwep commented Jul 14, 2019

This would be at least double the bundle size. Pickr is even now kinda heavy (Around 10Kb zipped). This may be something which could be done on top of pickr (You could use pickr as color-pickr and an additional library to justify your stops etc.)

@varunsridharan
Copy link
Author

@simonwep awesome thanks for your quick response. well since i am not a good js developer i have to wait untill some one could help me on this. but again your project is great and for sure i will be using it. in my WordPress Framework (WPOnion) 😄

@ryanlin1986
Copy link

Cann't find a gradient color picker for now, really expecting a gradient color picker.

@varunsridharan
Copy link
Author

@simonwep is it possible to create gradient as a add-on which can be in a separate file ?
I am not good at JavaScript. If not I would have contributed to this project by creating gradient picker
For now I can contribute by testing

@simonwep
Copy link
Owner

There won't and shouldn't be any direct extensions to pickr (regarding the core). Pickr should stay as it is since any more "bigger" features would increase the bundle size significantly (And the complexity would way to big as everything is written in vanilla js).

But I'm currently working on a small widget which is build on top of pickr (uses it as dependencies) which could be used for this purpose. I'll update this thread if there are any news, should be in the next days ;)

@varunsridharan
Copy link
Author

Awesome :-) well what i meant as a addon is something like dependencies which can be installed by the user as a separate package even if this addon not exists the core Pickr would work. this is what i meant :-0

@simonwep
Copy link
Owner

Oh okay :) Yeah, but I'd separate it into another package. Pickr's API is big enough to easily build things on-top of it without the access to the core.

Here is a quick demo of such a thing: https://simonwep.github.io/gpickr/index.html

@ryanlin1986 I won't have enough time to properly maintain it. If you want you could support me via. patreon - I already do my best to maintain the existing ones.

@varunsridharan
Copy link
Author

@simonwep you are awesome man :-) you really did a great job.

@varunsridharan
Copy link
Author

@simonwep i am unable to access the repo
And here some feedback

  1. The gradient pointer could be bit bigger
    image

@simonwep
Copy link
Owner

simonwep commented Jul 15, 2019

Whoops, I made it public - Yeah, I'll update it as soon as possible :)
Edit: And thank you regarding Open Collective :)

@ryanlin1986
Copy link

That's great to see the gradient picker already here

@varunsridharan
Copy link
Author

@simonwep as a open source developer I can't afford much but I did what I could do 😀
You don't know how much it means and you really did a big contribution towards WPonion project that I am working on.

FIY : I have been searching for a gradient picker for almost 2yrs now but I did not found anything useful

You are some super power 💪💪 created something in just in time..
You are great. Keep doing what you are doing 😀😃

@eldos777
Copy link

eldos777 commented Aug 1, 2019

Untitled

I created gradient

@varunsridharan
Copy link
Author

@eldos777 using ?

@simonwep
Copy link
Owner

simonwep commented Aug 1, 2019

@eldos777 I'm also interested, I think the easiest way would be to just enhance gpickr as it is haha

@eldos777
Copy link

eldos777 commented Aug 1, 2019

@varunsridharan : Writed code for gradient feature.

@varunsridharan
Copy link
Author

@eldos777 ok. but confusing 😕 why not explain bit more ?

@NateSeymour
Copy link
Collaborator

With the creating of gpickr, this topic appears to be resolved within the scope of pickr.

Please continue all gradient related discussion here: https://simonwep.github.io/gpickr/index.html, and have a wonderful day! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature requested wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

5 participants