Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Viselect v3.2.3 under jsDelivr missing viselect.esm.js.map #189

Closed
laukstein opened this issue Dec 29, 2022 · 8 comments
Closed

Viselect v3.2.3 under jsDelivr missing viselect.esm.js.map #189

laukstein opened this issue Dec 29, 2022 · 8 comments
Assignees
Labels
bug Something isn't working

Comments

@laukstein
Copy link

Viselect v3.2.3 released under jsDelivr https://cdn.jsdelivr.net/npm/@viselect/vanilla/lib/viselect.esm.js points to //# sourceMappingURL=viselect.esm.js.map but is missing the file under https://cdn.jsdelivr.net/npm/@viselect/vanilla/lib/viselect.esm.js.map, returns

{"version":3,"file":"viselect.esm.js","sources":[],"sourcesContent":[],"names":[],"mappings":""}
@laukstein laukstein added the unconfirmed Problem is not confirmed yet label Dec 29, 2022
@simonwep simonwep added bug Something isn't working and removed unconfirmed Problem is not confirmed yet labels Dec 30, 2022
@simonwep
Copy link
Owner

simonwep commented Dec 31, 2022

Seems to be a bigger issue (or rather - I'll refactor a lot to fix that). I'll switch entirely to vite for building it for production and refactor how the project is built next weekend! Should be fixed with that :)

This will also change the entry points of the library, so I guess this will be a new minor version.

@simonwep
Copy link
Owner

simonwep commented Jan 5, 2023

Fixed with changes in 411c2fc :)

@simonwep simonwep closed this as completed Jan 5, 2023
@simonwep
Copy link
Owner

simonwep commented Jan 5, 2023

Just a quick heads up: with v3.2.4 the location of the files for jsdelivr changed, so instead of .esm.js it's now https://cdn.jsdelivr.net/npm/@viselect/vanilla/dist/viselect.mjs and https://cdn.jsdelivr.net/npm/@viselect/vanilla/dist/viselect.mjs.map!

@laukstein
Copy link
Author

@simonwep
Copy link
Owner

simonwep commented Jan 5, 2023

Ah, goddammit - I meant https://cdn.jsdelivr.net/npm/@viselect/vanilla/dist/viselect.mjs 🤦 I'll updated the README's tomorrow... This whole refactoring got me confused 😕

@laukstein
Copy link
Author

@simonwep what about *.esm.js file? No longer supported?

@simonwep
Copy link
Owner

simonwep commented Jan 5, 2023

.esm.js is now .mjs (the official extension for ES6 module files)... The common-js version is still using the .js extension (e.g. universal module Format -> .umd.js)

In the release I mentioned that this may be a breaking change for some, but the build setup was really old (going back to 2018)... So this should be now state of the art.

Is this a problem for you? If your using nginx you might have to manually specify the mime type for .mjs files...

simonwep added a commit that referenced this issue Jan 5, 2023
@laukstein
Copy link
Author

No problem. Tested and so far looks working fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants