Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Configurable Max Queue Capacity Limit #425

Closed
daltonfury42 opened this issue Dec 12, 2020 · 2 comments
Closed

Add Configurable Max Queue Capacity Limit #425

daltonfury42 opened this issue Dec 12, 2020 · 2 comments
Labels
good first issue Good for newcomers You Can Do This Will be accepted on priority

Comments

@daltonfury42
Copy link
Collaborator

Admin can optionally configure a max capacity, after which new people will be put on hold.

This might add value in certain situations, but I am a bit reluctant, as it's not a core feature. For example, admin can also adjust without it, I feel.

@daltonfury42 daltonfury42 added the backend-blocked Blocked on backend support label Dec 12, 2020
@daltonfury42 daltonfury42 added the full-stack Requires work to be done at backend too label Jan 17, 2021
@daltonfury42
Copy link
Collaborator Author

daltonfury42 commented Mar 15, 2021

Create a new right side panel button to open a settings modal (use this as reference), in which we can add this as an optionally configurable entry.

Right now the modal would look empty with just one configuration item, but soon we will add more parameters.

image

To set the max queue capacity, send a patch request to /queue/{queueId}, example payload:

{
  "maxQueueCapacity": <some-number>
}

Currently we have not handled the case at backend side where we need it to be unlimited, so we can set a very high value say 100000 for now when the user wants to remove the limit.

@daltonfury42 daltonfury42 added good first issue Good for newcomers You Can Do This Will be accepted on priority and removed backend-blocked Blocked on backend support full-stack Requires work to be done at backend too labels Mar 15, 2021
@maaverik
Copy link
Collaborator

maaverik commented May 9, 2021

Closed by #603

@maaverik maaverik closed this as completed May 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers You Can Do This Will be accepted on priority
Projects
None yet
Development

No branches or pull requests

2 participants