Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reverted the @AuthenticationPrincipal change #45

Merged
merged 1 commit into from Jul 14, 2022

Conversation

Eukon05
Copy link
Contributor

@Eukon05 Eukon05 commented Jul 13, 2022

  • Modified JwtAuthenticationFilter to add only the username of the user to the principal object

  • Modified the testUser endpoint to reflect the change above

  • Modified the changeUserPassword method to reflect the change above

  • Fixed an antMatcher for changeUserPassword in WebSecurityConfig

Please refer to the Trello task for more details

- Modified JwtAuthenticationFilter to add only the username of the user to the principal object

- Modified the testUser endpoint to reflect the change above

- Modified the changeUserPassword method to reflect the change above

- Fixed an antMatcher for changeUserPassword in WebSecurityConfig
@dawciobiel
Copy link
Member

Implementation rejected - Spring Security OAuth implementation will be used instead

@dawciobiel dawciobiel closed this Jul 14, 2022
@Eukon05
Copy link
Contributor Author

Eukon05 commented Jul 14, 2022

This is a temporary fix, made only not to slow down progress on other tasks.
Spring Security OAuth will be implemented eventually, but in the meantime, I'd recommend sticking with our current approach.

@Eukon05 Eukon05 reopened this Jul 14, 2022
@dawciobiel dawciobiel merged commit f8006fd into Simple-as-Coding:main Jul 14, 2022
@Eukon05 Eukon05 deleted the fix-principal-object branch July 15, 2022 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants