feature/advertisement_history #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
MateuszBednarczyk
commented
Sep 12, 2022
MateuszBednarczyk
commented
- created getUsersAdvertisements method in controller
- created findAllByAuthor_Name method in repository
- created getUsersAdvertisements method and it's implementation
- created findAllByAuthor_Name method in repository - created getUsersAdvertisements method and it's implementation
- edited finding for users advertisements method, to order by creationDate - edited createAdvertisementEntity method
Eukon05
requested changes
Sep 13, 2022
src/main/java/pl/simpleascoding/tutoringplatform/domain/advertisement/Advertisement.java
Show resolved
Hide resolved
Eukon05
reviewed
Sep 23, 2022
| import org.springframework.data.jpa.repository.JpaRepository; | ||
| import pl.simpleascoding.tutoringplatform.domain.advertisement.Advertisement; | ||
|
|
||
| public interface AdvertisementRepository extends JpaRepository<Advertisement, Long> { | ||
| Page<Advertisement> findAllByAuthor_NameOrderByCreationDateDesc(String username, Pageable pageable); |
There was a problem hiding this comment.
You can add @PageableDefault or @SortDefault annotation to your controller method instead of a long JPA method name, but it's a valid approach and you don't need to change it if you don't want to.
Info about these annotations
Eukon05
approved these changes
Sep 23, 2022
There was a problem hiding this comment.
Everything looks good to me, except for the endpoint path advertisement/history/{username} (but it's because I'm used to a different style of REST paths).
We should decide on Discord on how we should name our endpoints (so that we maintain consistency throughout the entire api), but there are no other issues that I could find.
I approve.
dawciobiel
approved these changes
Sep 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.