-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add AuthenticateClientAsync #9
Comments
I know this is a really old issue, but as I get myself off Should we do the same thing here, then? I'm worried it might mean some people might not know how to use/consume this? I don't need to have an async controller/module to call the async method .. correct? @phillip-haydon i'm dragging you into this conversation for your thoughts, also. |
What .NET version do we currently want to target minimum? |
This line of code says it's .NET 4.0. Is the System.Net.HttpClient class .NET 4.0+ ? or just 4.5? |
Pretty sure its 4.5 |
|
@PureKrome remove all the sync functions and return Task (though this would be breaking change). It will support .net 4.0 if you don't use async/await. If they want sync they can use |
If that's the case when we should support 4.0. Atleast for V1. We can decide at V2 when we introduce Claims and Owin if we should go 4.5 only. |
@prabirshrestha now that i've finally learnt |
add
AuthenticateClientAsync
too so http requests can be done in an async fashion.The text was updated successfully, but these errors were encountered: