Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add AuthenticateClientAsync #9

Open
prabirshrestha opened this issue Oct 28, 2012 · 8 comments
Open

add AuthenticateClientAsync #9

prabirshrestha opened this issue Oct 28, 2012 · 8 comments

Comments

@prabirshrestha
Copy link

add AuthenticateClientAsync too so http requests can be done in an async fashion.

@PureKrome
Copy link
Member

I know this is a really old issue, but as I get myself off RestSharp and onto HttpClient ... i've noticed that HttpClient only offer async methods.

Should we do the same thing here, then?

I'm worried it might mean some people might not know how to use/consume this?

I don't need to have an async controller/module to call the async method .. correct?

@phillip-haydon i'm dragging you into this conversation for your thoughts, also.

@phillip-haydon
Copy link
Member

What .NET version do we currently want to target minimum?

@PureKrome
Copy link
Member

This line of code says it's .NET 4.0.

Is the System.Net.HttpClient class .NET 4.0+ ? or just 4.5?

@phillip-haydon
Copy link
Member

Pretty sure its 4.5

@PureKrome
Copy link
Member

Offical NuGet package.

Supported Platforms:

  • .NET Framework 4
  • .NET for Windows Store apps
  • Windows Phone 7.5 and 8
  • Silverlight 4 and 5
  • Portable Class Libraries

@prabirshrestha
Copy link
Author

@PureKrome remove all the sync functions and return Task (though this would be breaking change). It will support .net 4.0 if you don't use async/await.

If they want sync they can use AuthenticateClientAsync().Result which will be useful during migration.

@phillip-haydon
Copy link
Member

If that's the case when we should support 4.0. Atleast for V1. We can decide at V2 when we introduce Claims and Owin if we should go 4.5 only.

@PureKrome
Copy link
Member

@prabirshrestha now that i've finally learnt async/await, this is now scheduled on the 2.0 release. (I have it nearly working on a branch on my localhost, btw).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants