Merge pull request #15 from sroze/proper-consumer-return

Updates the return value to match with the OldSound bundle
SimpleBus · Sep 29, 2015 · dca0bdd · dca0bdd
2 parents 34581c2 + fa6498c
commit dca0bdd
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/src/RabbitMQMessageConsumer.php b/src/RabbitMQMessageConsumer.php
@@ -39,14 +39,14 @@ public function execute(AMQPMessage $msg)
                 new MessageConsumed($msg)
             );
 
-            return self::MSG_ACK;
+            return true;
         } catch (Exception $exception) {
             $this->eventDispatcher->dispatch(
                 Events::MESSAGE_CONSUMPTION_FAILED,
                 new MessageConsumptionFailed($msg, $exception)
             );
 
-            return self::MSG_REJECT;
+            return false;
         }
     }
 }
diff --git a/tests/RabbitMQMessageConsumerTest.php b/tests/RabbitMQMessageConsumerTest.php
@@ -29,7 +29,7 @@ public function it_consumes_the_message_body_as_a_serialized_envelope()
         $consumer = new RabbitMQMessageConsumer($serializedEnvelopeConsumer, $eventDispatcher);
 
         $result = $consumer->execute($message);
-        $this->assertSame(ConsumerInterface::MSG_ACK, $result);
+        $this->assertSame(true, $result);
     }
 
     /**
@@ -50,7 +50,7 @@ public function it_handles_an_error_but_throws_no_exception_if_consuming_the_mes
         $consumer = new RabbitMQMessageConsumer($serializedEnvelopeConsumer, $eventDispatcher);
 
         $result = $consumer->execute($message);
-        $this->assertSame(ConsumerInterface::MSG_REJECT, $result);
+        $this->assertSame(false, $result);
     }
 
     private function newAMQPMessage($messageBody = '')