Upgrader - CLI - custom_avatar & $upgradeData

[sbulen]

Description

Two issues specific to upgrading via the CLI:

• If the prior version didn't have a custom_avatar directory, it is somehow not created upon upgrade
• $upgradeData is left in Settings.php when done

Steps to reproduce

1. Do an upgrade via CLI on a pure vanilla 2.0 or 1.x implementation with no custom avs directory setup

Environment (complete as necessary)

• Version/Git revision: Today
• Database Type: mysql
• Database Version: 5.7
• PHP Version: 7.3

Additional information/references

Errors from trying to upload an avatar:

The problem is the folder & url weren't setup by the upgrader:

$upgradeData is still in Settings.php:

[sbulen]

I'm not quite sure how deep to go here. I have been focusing on reporting errors from 2.0=>2.1 upgrades thus far via CLI. 1.x=>2.1 produces many, many more errors & gaps in functionality.

Browser upgrades are far more robust than CLI at the moment... Especially the further back you go.

[jdarwood007]

Focus mostly on 2.0 to 2.1. Unless you can prove that the 1.1 to 2.0 worked and the 1.1 to 2.1 does not.