Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

$context['login_cookie_times'] not defined when resetting forgotten password #6179

Closed
Oldiesmann opened this issue Jul 20, 2020 · 1 comment · Fixed by #6196
Closed

$context['login_cookie_times'] not defined when resetting forgotten password #6179

Oldiesmann opened this issue Jul 20, 2020 · 1 comment · Fixed by #6196
Milestone

Comments

@Oldiesmann
Copy link
Contributor

Oldiesmann commented Jul 20, 2020

Description

Saw this in the error log of one of the forums I run. Not sure if it's been fixed yet or not.

Environment (complete as necessary)

  • Version/Git revision: RC2, not sure which revision
  • Database Type: MariaDB
  • Database Version: 10.2.31
  • PHP Version: 7.3.20
Type of error: General
Error message: 2: Invalid argument supplied for foreach()
File: /.../Themes/default/Login.template.php
Line: 58
URL of page causing the error: .../index.php?action=reminder;sa=setpassword2
Backtrace information
#0: smf_error_handler()
Called from /.../Themes/default/Login.template.php on line 58
#1: template_login()
Called from /.../Sources/Load.php on line 2479
#2: loadSubTemplate()
Called from /.../Sources/Subs.php on line 3279
#3: obExit()
Called from /.../index.php on line 154

I also have an "Undefined index: login_cookie_times" error on the same line.

@Oldiesmann Oldiesmann changed the title Undefined index: login_cookie_times when changing forgotten password $context['login_cookie_times'] not defined when resetting forgotten password Jul 20, 2020
@MissAllSunday
Copy link
Contributor

Looks like it was already reported: #4886

It seems we still need to move the declaration earlier in the process and since the context var is basically constants theres no real harm in doing so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants