Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.0]: Adding calendar event can cause max_execution_time to be exceeded #8232

Closed
Oldiesmann opened this issue May 19, 2024 · 3 comments · Fixed by #8234
Closed

[3.0]: Adding calendar event can cause max_execution_time to be exceeded #8232

Oldiesmann opened this issue May 19, 2024 · 3 comments · Fixed by #8234
Assignees
Labels
Milestone

Comments

@Oldiesmann
Copy link
Contributor

Basic Information

When adding a new recurring event, it's possible for it to hit PHP's max_execution_time. We should add the standard SMF timeout handling stuff (like what we do for creating search indexes, etc.) to this as well.

Steps to reproduce

  1. Create a new event in the calendar that repeats a lot of times (every day or month "forever" did it for me)
  2. You'll eventually run into max_execution_time

Expected result

Event actually posts

Actual result

PHP timeout

Version/Git revision

68b6c73

Database Engine

All

Database Version

10.11.8-MariaDB-ubu2204

PHP Version

8.3.7

Logs

AH01071: Got error 'PHP message: PHP Fatal error: Maximum execution time of 30 seconds exceeded in /.../Sources/Calendar/RecurrenceIterator.php on line 806', referer: .../index.php?action=calendar;sa=post

Additional Information

We should probably look into adding the standard "timeout protection" functionality (like with creating search indexes for example) to handle this. Although it's not likely to have an event running every month or day for the next 6 years (based on the current max year of 2030), we should do our best to support it if possible.

@Sesquipedalian
Copy link
Member

Can you tell me the start date, duration, and recurrence rule settings that you used when you encountered this?

I did a lot of testing with events that recurred forever, and I never ran into this.

@Oldiesmann
Copy link
Contributor Author

I was able to trigger it easily with this setup - start today, go all day, repeat monthly "forever". Max date in the admin center is still 2030.
image

@Sesquipedalian Sesquipedalian added this to the 3.0 Alpha 2 milestone May 20, 2024
@Sesquipedalian Sesquipedalian self-assigned this May 20, 2024
@Sesquipedalian
Copy link
Member

Confirmed. A fix will be submitted shortly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants