Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

action register not cought by dont allow guests to browse the forum #2667

Closed
illori opened this issue Jan 12, 2015 · 1 comment · Fixed by #2672
Closed

action register not cought by dont allow guests to browse the forum #2667

illori opened this issue Jan 12, 2015 · 1 comment · Fixed by #2672

Comments

@illori
Copy link
Contributor

illori commented Jan 12, 2015

if in the admin panel you select not to allow guests to browse the forum and go to the old register action github2.1/index.php?action=register you can still view the board index, this should not be possible.

other actions lead to the correct error page telling the user to register.

some cleanup still required for the old register action?

@margarett
Copy link
Contributor

Yes, index.php

    // If guest access is off, a guest can only do one of the very few following actions.
    elseif (empty($modSettings['allow_guestAccess']) && $user_info['is_guest'] && (!isset($_REQUEST['action']) || !in_array($_REQUEST['action'], array('coppa', 'login', 'login2', 'register', 'register2', 'reminder', 'activate', 'help', 'helpadmin', 'smstats', 'verificationcode', 'signup', 'signup2'))))
        return 'KickGuest';

register and register2 should be removed from this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants