Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Two-Factor Authentication enabled? #2792

Closed
illori opened this issue Mar 25, 2015 · 7 comments · Fixed by #2803
Closed

Two-Factor Authentication enabled? #2792

illori opened this issue Mar 25, 2015 · 7 comments · Fixed by #2803

Comments

@illori
Copy link
Contributor

illori commented Mar 25, 2015

i have not enabled this feature but on the cookies and sessions page the drop down shows "enabled". it should not show enabled if i have not selected it to be enabled.

why have a drop down when the only options are enable/disable? a checkbox could do that easily.

i did try to log in and i was not redirected to the config page for 2fa.

does the admin really need to setup their own account for 2fa before others can?

the text says "Please enable 2FA in your account in order to be able to force 2FA on other users!"

@Dragooon
Copy link
Contributor

i have not enabled this feature but on the cookies and sessions page the drop down shows "enabled". it should not show enabled if i have not selected it to be enabled.

It's enabled by default

why have a drop down when the only options are enable/disable? a checkbox could do that easily.

It gives a third option to force 2fa when the admin has enabled it

i did try to log in and i was not redirected to the config page for 2fa.

That's only when you're forcing 2FA

does the admin really need to setup their own account for 2fa before others can?

Yes, this it to prevent admins from locking themselves out.

@illori
Copy link
Contributor Author

illori commented Mar 25, 2015

Maybe some additional information would be useful. Right now if seems that
most admin will not know what this feature is or how it works.
On Mar 25, 2015 12:41 PM, "Shitiz Garg" notifications@github.com wrote:

i have not enabled this feature but on the cookies and sessions page the
drop down shows "enabled". it should not show enabled if i have not
selected it to be enabled.

It's enabled by default

why have a drop down when the only options are enable/disable? a checkbox
could do that easily.

It gives a third option to force 2fa when the admin has enabled it

i did try to log in and i was not redirected to the config page for 2fa.

That's only when you're forcing 2FA

does the admin really need to setup their own account for 2fa before
others can?

Yes, this it to prevent admins from locking themselves out.


Reply to this email directly or view it on GitHub
#2792 (comment)
.

@margarett
Copy link
Contributor

I would say that it's more or less self-explanatory, if you know what you're searching for. And I would say that if the admin doesn't know what he's dealing with, he should leave 2FA disabled...

I do agree that this does require a wiki article ;)

@illori
Copy link
Contributor Author

illori commented Mar 25, 2015

or maybe a help popup to explain a bit more? we could add a bit to the wiki but i would not say it is the first stop.

@margarett
Copy link
Contributor

What do you think about this?
margarett@82d2953
(no PR yet, I think that it might require some "love" regarding proper English)

@illori
Copy link
Contributor Author

illori commented Mar 27, 2015

looks good to me. that should help with this issue.

@ChainyEO
Copy link

I left a comment about the language: #2803

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants