Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Login2() illogical statement #2969

Closed
jasonclemons opened this issue Aug 11, 2015 · 0 comments
Closed

Login2() illogical statement #2969

jasonclemons opened this issue Aug 11, 2015 · 0 comments
Milestone

Comments

@jasonclemons
Copy link

As per: http://www.simplemachines.org/community/index.php?topic=538793.0

Line 182: LogInOut.php

    elseif (!empty($_POST['cookielength']) && ($_POST['cookielength'] >= 1 || $_POST['cookielength'] <= 525600))
        $modSettings['cookieTime'] = (int) $_POST['cookielength'];

The part that doesn't make sense is this:

($_POST['cookielength'] >= 1 || $_POST['cookielength'] <= 525600)

as that part of the statement will always return true. My guess is that the operator should be && not ||, but it does require some further investigation.

@live627 live627 added this to the Beta 3 milestone Aug 11, 2015
live627 added a commit that referenced this issue Aug 15, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants