Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

integrate_profile_areas #3945

Closed
Underdog-01 opened this issue Feb 18, 2017 · 3 comments
Closed

integrate_profile_areas #3945

Underdog-01 opened this issue Feb 18, 2017 · 3 comments

Comments

@Underdog-01
Copy link
Contributor

Question:

Someone edited Profile.php at some point and changed the integration hook name of "integrate_profile_areas" to "integrate_pre_profile_areas".

Currently I do not see any issue with older mods working with the same hook (with the original function name) but now one must adjust this within a mod's install files.

Is there a good reason for renaming it or is it a mistake?

Regards.

@Underdog-01
Copy link
Contributor Author

Underdog-01 commented Feb 19, 2017

Ok, I see the change here:
085840a

... but where is the other function call & why wouldn't one rename the other one (assuming it exists) to maintain backward compatibility?

I do not see the original function in any other profile file therefore at the moment it does not appear as a duplicate.

@tinoest
Copy link
Contributor

tinoest commented Feb 19, 2017

It is made up in the string you linked to.

call_integration_hook('integrate_' . $menu_context['current_action']...

Where menu_context is equal to profile

@jdarwood007
Copy link
Member

#3118

Read the related issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants