parse_bbc Undefined index: browser

[albertlast]

Description

When parse_bbc is called by cronjob the $context['browser']['is_ie'] is not setted.
https://www.simplemachines.org/community/index.php?topic=562323.0

i guess

Steps to reproduce

1. marke a post to notify
2. create a post with bbc code

Environment (complete as necessary)

• Version/Git revision:newest
• Database Type:
• Database Version:
• PHP Version:

Additional information/references

stacktrace

https://github.com/SimpleMachines/SMF2.1/blob/8aafc85d03b52eb6780a5ff9ac61d4f7aad9d987/Sources/Subs.php#L1742

Possible introduce by @MissAllSunday
with pr 5fdfd87

[MissAllSunday]

Yay for adding legacy BBC..... still cannot understand why people want those tags so badly..........

At this point, the is_ie thing should be completely erased, unless of course people starts to complaining about not supporting IE 6 in order to view their precious move and blink BB codes.............

[albertlast]

ther are many placed where this check is placed,
would you create pr with the removing of this?

[MissAllSunday]

Or set every browser context related vars to null or false or any other falsy value when running in cli mode.

[albertlast]

Feel free to choose your way how to solve this.

[Sesquipedalian]

The easiest fix would be to use !empty($context['browser']['is_ie']).