Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should the cache work under SSI? #5061

Closed
live627 opened this issue Oct 16, 2018 · 2 comments
Closed

Should the cache work under SSI? #5061

live627 opened this issue Oct 16, 2018 · 2 comments
Assignees
@jdarwood007
Milestone
RC1

Comments

@live627
Copy link
Contributor

live627 commented Oct 16, 2018

Description

Because right now it doesn't work.

Steps to reproduce

  1. Enable file cache
  2. cache get/put do nothing

Environment (complete as necessary)

  • Version/Git revision:last Thursday
  • Database Type:blah
  • Database Version:blah
  • PHP Version:7.2

Additional information/references

Missing global declaration

This implies that I have a fix and will send it in upon confirmation.
@albertlast
Copy link
Collaborator

What are the pro and con?

@jdarwood007 jdarwood007 self-assigned this Oct 16, 2018
@jdarwood007
Copy link
Member

It should work under SSI. Will look into it.

live627 added a commit to live627/SMF2.1 that referenced this issue Oct 16, 2018
@live627
$cache_enable should be defined as a global var in SSI
64f957e 
Fixes SimpleMachines#5061

Signed-off-by: John Rayes <live627@gmail.com>
@live627 live627 mentioned this issue Oct 16, 2018
Merged
@live627 live627 added this to the RC 1 milestone Nov 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jdarwood007 jdarwood007

Labels
None yet
Projects
None yet
Milestone
RC1
Development

No branches or pull requests
3 participants
@live627 @jdarwood007 @albertlast