Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Who's Online almost always reports the member activity as "Viewing their own profile" #5356

Closed
Sesquipedalian opened this issue Jan 22, 2019 · 9 comments
Milestone

Comments

@Sesquipedalian
Copy link
Member

Description

See https://www.simplemachines.org/community/index.php?topic=564454.0.

Environment (complete as necessary)

Additional information/references

Looking at the log_online table, the problem appears to be that AJAX calls to fetch alerts are being logged. This action should be excluded from logging.

Sesquipedalian added a commit to Sesquipedalian/SMF that referenced this issue Jan 22, 2019
@smfbigguy
Copy link

I just tried this and it still shows as they are viewing their profile. I will give it a bit and see if it changes. I have cleared all my cache.

@smfbigguy
Copy link

No, this does not work. Still shows users viewing their profile.

@smfbigguy
Copy link

I noticed this line in the index.php file:
unset($no_stat_actions);

Just below where this new edit goes.

But nothing for:
$no_stat_areas

So I added this:
unset($no_stat_areas);

I have no idea if that is right but it made sense to me to add it and I have no idea if it works, lol. Just thought I would try it I guess.

@smfbigguy
Copy link

Well, my above post does nothing, lol. I really didn't expect it to but I thought I would try.

@live627
Copy link
Contributor

live627 commented Jan 23, 2019

Try to replace

	if (empty($_REQUEST['action']) || !in_array($_REQUEST['action'], $no_stat_actions) || !isset($no_stat_areas[$_REQUEST['action']]) || !isset($_REQUEST['area']) || $no_stat_areas[$_REQUEST['action']] != $_REQUEST['area'])

with

	if (isset($_REQUEST['action']) && in_array($_REQUEST['action'], $no_stat_actions) || isset($no_stat_areas[$_REQUEST['action']]) && isset($_REQUEST['area']) && $no_stat_areas[$_REQUEST['action']] = $_REQUEST['area'])

I haven't tested this because... reasons...

@smfbigguy
Copy link

Took out my change and put yours in. Now I just gotta wait for members to show up.

@smfbigguy
Copy link

Type of error: Undefined_vars
Error message: 8: Undefined index: action
File: /home/******/public_html/index.php
Line: 209
URL of page causing the error: https://www.whatsurbeef.net/index.php?https://www.whatsurbeef.net/

@smfbigguy
Copy link

Took your change out and mine.

@Sesquipedalian
Copy link
Member Author

It would be a lot easier to follow your feedback regarding the changes in my PR if you made the comments in the discussion for the PR rather than the discussion of the bug. 😉

@Sesquipedalian Sesquipedalian added this to the RC2 milestone Jan 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants