Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing the language redirects to index.php #5625

Closed
m4z opened this issue Apr 25, 2019 · 2 comments · Fixed by #6562
Closed

Changing the language redirects to index.php #5625

m4z opened this issue Apr 25, 2019 · 2 comments · Fixed by #6562

Comments

@m4z
Copy link

m4z commented Apr 25, 2019

Description

Changing the language from the top-right dropdown menu redirects to index.php?language=foo. Is there a technical reason for this? Could it be changed to redirect to <current deeplink>?language=foo?
Currently, I either have to re-click my way back into the maze that is, for example, the admin center, or use my browsers back button and reload to see the language change.

Steps to reproduce

  1. Install another language in your forum
  2. While n clicks deep into some random forum function, change the language
  3. Find yourself being redirected to the forum front page

Environment (complete as necessary)

  • Version/Git revision: HEAD
@albertlast
Copy link
Collaborator

For ther deeplink maybe some addional information are needed like the post stuff or the anker information,
both would create mutch complexity with less gain.

@Sesquipedalian
Copy link
Member

Sesquipedalian commented Apr 26, 2019

We do maintain a note of the user's current URL during their session1 so that we can redirect the user back to it after certain actions (e.g. login). Redirecting after changing languages should be possible if we extend that system to include the action of changing languages.


1 A note for any privacy conscious readers: This is an ephemeral record only of the current URL you are visiting at the moment, not a record of where you have been. Whenever you go to a new page, the previous URL is forgotten, and the record is deleted entirely after you leave the site.

@Sesquipedalian Sesquipedalian added this to the Final milestone Apr 26, 2019
BrickOzp pushed a commit to BrickOzp/SMF2.1 that referenced this issue Mar 8, 2021
Try to redirect the user to the same page after changing
of language.

Fixes SimpleMachines#5625

Signed-off-by: Oscar Rydhé oscar.rydhe@gmail.com
BrickOzp pushed a commit to BrickOzp/SMF2.1 that referenced this issue Mar 8, 2021
Redirect to old url after language change.

Fixes SimpleMachines#5625

Signed-off-by: Oscar Rydhé oscar.rydhe@gmail.com
BrickOzp pushed a commit to BrickOzp/SMF2.1 that referenced this issue Mar 9, 2021
Redirect to old url after language change.

Fixes SimpleMachines#5625

Signed-off-by: Oscar Rydhé oscar.rydhe@gmail.com
live627 pushed a commit that referenced this issue Mar 11, 2021
Redirect to old url after language change.

Fixes #5625

Signed-off-by: Oscar Rydhé oscar.rydhe@gmail.com

Co-authored-by: Oscar Rydhé <oscar.rydhe@sony.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants